Fix openai: transition functions should always return state

Author: ovistoica

src/simulflow/processors/openai.clj

@@ -138,10 +138,11 @@
             ::flow/out-ports {::llm-write llm-write}})))
 
 (defn transition
-  [{::flow/keys [in-ports out-ports]} transition]
+  [{::flow/keys [in-ports out-ports] :as state} transition]
   (when (= transition ::flow/stop)
     (doseq [port (concat (vals in-ports) (vals out-ports))]
-      (a/close! port))))
+      (a/close! port)))
+  state)
 
 (defn transform-handle-llm-response
   "Handle the streaming response from the LLM. Return appropriate frames based on

test/simulflow/processors/openai_test.clj

@@ -236,11 +236,11 @@
     ;; This test would need mock channels to verify closure
     ;; For now, just test that the function exists and doesn't throw
     (let [mock-state {:clojure.core.async.flow/in-ports {} :clojure.core.async.flow/out-ports {}}]
-      (is (nil? (openai/transition mock-state :clojure.core.async.flow/stop)))))
+      (is (= (openai/transition mock-state :clojure.core.async.flow/stop) mock-state))))
 
   (testing "ignores non-stop transitions"
     (let [mock-state {:clojure.core.async.flow/in-ports {} :clojure.core.async.flow/out-ports {}}]
-      (is (nil? (openai/transition mock-state :clojure.core.async.flow/start))))))
+      (is (= (openai/transition mock-state :clojure.core.async.flow/start) mock-state)))))
 
 (deftest openai-multi-arity-fn-test
   (testing "0-arity returns describe"
@@ -251,7 +251,7 @@
 
   (testing "2-arity delegates to transition"
     (let [mock-state {:clojure.core.async.flow/in-ports {} :clojure.core.async.flow/out-ports {}}]
-      (is (nil? (openai/openai-llm-fn mock-state :clojure.core.async.flow/stop)))))
+      (is (= mock-state (openai/openai-llm-fn mock-state :clojure.core.async.flow/stop)))))
 
   (testing "3-arity delegates to transform"
     (let [context-frame (frame/llm-context {:messages [{:role :system :content "You are helpful"}] :tools []})