rsc: Add profiling script #1566
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ag-eitilt
reviewed
May 24, 2024
Collaborator
ag-eitilt
left a comment
ag-eitilt
left a comment
There was a problem hiding this comment.
Is this a PR you're hoping to get a review on, or did you just push it for future reference? I can't quite tell from the description.
Comment on lines
+34
to
+36
| "cmd": [47,117,115,114], | ||
| "cwd":".", | ||
| "env":[80,65,84,72,61,47], |
Collaborator
There was a problem hiding this comment.
Are these seemingly-magic numbers documented anywhere?
Contributor
Author
There was a problem hiding this comment.
These numbers themselves are made up. Its just the byte representation of the command/environment string of the job. The fact that you need to serialize those values into a byte array is documented in the api type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I threw together a basic script for profiling the rsc. Nothing too fancy but useful for evaluating potential performance changes.