Skip to content

Commit 3b8ef15

Browse files
committed
comments fix
1 parent 6269b6d commit 3b8ef15

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

anchor/validator_store/src/metadata_service.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,10 @@ impl<E: EthSpec, T: SlotClock + 'static> MetadataService<E, T> {
9292
let slot = self.slot_clock.now().ok_or("Failed to read slot clock")?;
9393

9494
let attestation_data = if self.weighted_attestation_data {
95+
info!("Using weighted attestation calculation");
9596
self.weighted_calculation(slot).await?
9697
} else {
98+
info!("Using first_success fallback");
9799
self.beacon_nodes
98100
.first_success(|beacon_node| async move {
99101
let _timer = validator_metrics::start_timer_vec(
@@ -385,7 +387,7 @@ impl<E: EthSpec, T: SlotClock + 'static> MetadataService<E, T> {
385387
let attestation_slot_u64 = slot.as_u64();
386388
let head_slot_u64 = head_slot.as_u64();
387389

388-
if head_slot_u64 <= attestation_slot_u64 {
390+
if head_slot_u64 < attestation_slot_u64 {
389391
// Increase score based on the nearness of the head slot
390392
let distance = attestation_slot_u64 - head_slot_u64;
391393
let bonus = 1.0 / (1 + distance) as f64;
@@ -409,7 +411,7 @@ impl<E: EthSpec, T: SlotClock + 'static> MetadataService<E, T> {
409411
client = %client_addr,
410412
head_slot = head_slot_u64,
411413
attestation_slot = attestation_slot_u64,
412-
"Block slot is after attestation slot, skipping proximity bonus"
414+
"Block slot is the same or after attestation slot, skipping proximity bonus"
413415
);
414416
base_score
415417
}
@@ -432,7 +434,6 @@ impl<E: EthSpec, T: SlotClock + 'static> MetadataService<E, T> {
432434
}
433435

434436
/// Get the slot number for a given block root with timeout
435-
// Does this retry??
436437
async fn get_block_slot(
437438
&self,
438439
client: &BeaconNodeHttpClient,

0 commit comments

Comments
 (0)