fix(quickbooks): declare the bill payment and purchase order fields the contracts dropped

A contract body is a Zod object, so any key it does not declare is stripped
before the provider operation runs - silently, with no validation error. The
contracts were authored before currencyCode/apAccountId/documentNumber were
added to Create Bill Payment and dueDate to Update Purchase Order, so those
params were dead: the block forwarded them and they never reached Intuit.

Adds a parity test across all twelve contract-bound operations so a param added
to a tool without its contract fails instead of silently disappearing.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RB5M2gk7zZgGomnQqr7WRB

Author: waleedlatif1

apps/sim/lib/api/contracts/tools/quickbooks.ts

@@ -310,6 +310,9 @@ export const quickBooksCreateBillPaymentBodySchema = quickBooksAuthSchema.extend
   paymentAccountId: requiredQuickBooksId('paymentAccountId'),
   billAllocations: quickBooksBillAllocationsSchema.optional(),
   transactionDate: optionalQuickBooksDate('transactionDate'),
+  apAccountId: optionalQuickBooksId('apAccountId'),
+  currencyCode: optionalQuickBooksText('currencyCode', 8),
+  documentNumber: optionalQuickBooksText('documentNumber', 256),
   privateNote: optionalQuickBooksText('privateNote', 4000),
   requestId: optionalQuickBooksText('requestId', 256),
 })
@@ -407,6 +410,7 @@ export const quickBooksUpdatePurchaseOrderBodySchema = quickBooksAuthSchema.exte
   vendorId: optionalQuickBooksId('vendorId'),
   apAccountId: optionalQuickBooksId('apAccountId'),
   transactionDate: optionalQuickBooksDate('transactionDate'),
+  dueDate: optionalQuickBooksDate('dueDate'),
   documentNumber: optionalQuickBooksText('documentNumber', 256),
   privateNote: optionalQuickBooksText('privateNote', 4000),
 })

apps/sim/lib/internal/quickbooks/contract-param-parity.test.ts

@@ -0,0 +1,75 @@
+/**
+ * @vitest-environment node
+ */
+import { describe, expect, it } from 'vitest'
+import {
+  quickBooksCreateBillPaymentContract,
+  quickBooksUpdateBillContract,
+  quickBooksUpdateBillPaymentContract,
+  quickBooksUpdateCreditMemoContract,
+  quickBooksUpdateCustomerPaymentContract,
+  quickBooksUpdateEmployeeContract,
+  quickBooksUpdateItemContract,
+  quickBooksUpdatePurchaseContract,
+  quickBooksUpdatePurchaseOrderContract,
+  quickBooksUpdateRefundReceiptContract,
+  quickBooksUpdateVendorContract,
+  quickBooksUpdateVendorCreditContract,
+} from '@/lib/api/contracts/tools/quickbooks'
+import { quickbooksCreateBillPaymentTool } from '@/tools/quickbooks/create_bill_payment'
+import { quickbooksUpdateBillTool } from '@/tools/quickbooks/update_bill'
+import { quickbooksUpdateBillPaymentTool } from '@/tools/quickbooks/update_bill_payment'
+import { quickbooksUpdateCreditMemoTool } from '@/tools/quickbooks/update_credit_memo'
+import { quickbooksUpdateCustomerPaymentTool } from '@/tools/quickbooks/update_customer_payment'
+import { quickbooksUpdateEmployeeTool } from '@/tools/quickbooks/update_employee'
+import { quickbooksUpdateItemTool } from '@/tools/quickbooks/update_item'
+import { quickbooksUpdatePurchaseTool } from '@/tools/quickbooks/update_purchase'
+import { quickbooksUpdatePurchaseOrderTool } from '@/tools/quickbooks/update_purchase_order'
+import { quickbooksUpdateRefundReceiptTool } from '@/tools/quickbooks/update_refund_receipt'
+import { quickbooksUpdateVendorTool } from '@/tools/quickbooks/update_vendor'
+import { quickbooksUpdateVendorCreditTool } from '@/tools/quickbooks/update_vendor_credit'
+
+/**
+ * A contract body is a Zod object, so any key it does not declare is STRIPPED
+ * before the provider operation runs — silently, with no validation error. A
+ * tool param that the contract omits is therefore dead: the user fills it in,
+ * the block forwards it, and it never reaches Intuit.
+ */
+const CONTRACT_BOUND_OPERATIONS = [
+  ['create_bill_payment', quickbooksCreateBillPaymentTool, quickBooksCreateBillPaymentContract],
+  ['update_bill', quickbooksUpdateBillTool, quickBooksUpdateBillContract],
+  ['update_bill_payment', quickbooksUpdateBillPaymentTool, quickBooksUpdateBillPaymentContract],
+  ['update_credit_memo', quickbooksUpdateCreditMemoTool, quickBooksUpdateCreditMemoContract],
+  [
+    'update_customer_payment',
+    quickbooksUpdateCustomerPaymentTool,
+    quickBooksUpdateCustomerPaymentContract,
+  ],
+  ['update_employee', quickbooksUpdateEmployeeTool, quickBooksUpdateEmployeeContract],
+  ['update_item', quickbooksUpdateItemTool, quickBooksUpdateItemContract],
+  ['update_purchase', quickbooksUpdatePurchaseTool, quickBooksUpdatePurchaseContract],
+  [
+    'update_purchase_order',
+    quickbooksUpdatePurchaseOrderTool,
+    quickBooksUpdatePurchaseOrderContract,
+  ],
+  [
+    'update_refund_receipt',
+    quickbooksUpdateRefundReceiptTool,
+    quickBooksUpdateRefundReceiptContract,
+  ],
+  ['update_vendor', quickbooksUpdateVendorTool, quickBooksUpdateVendorContract],
+  ['update_vendor_credit', quickbooksUpdateVendorCreditTool, quickBooksUpdateVendorCreditContract],
+] as const
+
+describe('QuickBooks contract/tool param parity', () => {
+  it.each(CONTRACT_BOUND_OPERATIONS)(
+    '%s declares every tool param in its contract body',
+    (_name, tool, contract) => {
+      const bodyShape = (contract.body as unknown as { shape: Record<string, unknown> }).shape
+      const declared = new Set(Object.keys(bodyShape))
+      const dropped = Object.keys(tool.params).filter((param) => !declared.has(param))
+      expect(dropped).toEqual([])
+    }
+  )
+})