Symbol: validate tokens in constructor

sirbrillig · sirbrillig · commit 92472abe4eee · 2018-09-11T10:59:15.000-04:00
diff --git a/ImportDetection/Symbol.php b/ImportDetection/Symbol.php
@@ -8,7 +8,12 @@ class Symbol {
 
 	public function __construct(array $tokens) {
 		if (empty($tokens)) {
-			throw new \Exception('Symbols cannot be empty');
+			throw new \Exception('Cannot construct Symbol with no tokens');
+		}
+		foreach ($tokens as $token) {
+			if (empty($token) || ! is_array($token)) {
+				throw new \Exception('Cannot construct Symbol with invalid token: ' . var_export($token, true));
+			}
 		}
 		$this->tokens = $tokens;
 	}

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,12 @@ class Symbol {`
`8`	`8`
`9`	`9`	`public function __construct(array $tokens) {`
`10`	`10`	`if (empty($tokens)) {`
`11`		`- throw new \Exception('Symbols cannot be empty');`
	`11`	`+ throw new \Exception('Cannot construct Symbol with no tokens');`
	`12`	`+ }`
	`13`	`+ foreach ($tokens as $token) {`
	`14`	`+ if (empty($token) \|\| ! is_array($token)) {`
	`15`	`+ throw new \Exception('Cannot construct Symbol with invalid token: ' . var_export($token, true));`
	`16`	`+ }`
`12`	`17`	`}`
`13`	`18`	`$this->tokens = $tokens;`
`14`	`19`	`}`