Potential bug in clipboard.ts onCaptureCopy calling e.preventDefault() prematurely

[anisabboud]

Quill.js adds a 'copy' event listener on the editor, which calls onCaptureCopy().

quill/packages/quill/src/modules/clipboard.ts

Lines 83 to 85 in ebe16ca

	this.quill.root.addEventListener('copy', (e) =>
	this.onCaptureCopy(e, false),
	);

onCaptureCopy() calls e.preventDefault() to handle the copy event by quill:

quill/packages/quill/src/modules/clipboard.ts

Lines 171 to 182 in ebe16ca

	onCaptureCopy(e: ClipboardEvent, isCut = false) {
	if (e.defaultPrevented) return;
	e.preventDefault();
	const [range] = this.quill.selection.getRange();
	if (range == null) return;
	const { html, text } = this.onCopy(range, isCut);
	e.clipboardData?.setData('text/plain', text);
	e.clipboardData?.setData('text/html', html);
	if (isCut) {
	deleteRange({ range, quill: this.quill });
	}
	}

But there is a case, where quill.selection.getRange() returns null, and the function returns without copying anything but after it has already called e.preventDefault(), so the browser doesn't copy anything either.
I think e.preventDefault(); should move two lines down, after the if (range == null) return;.
I.e., onCaptureCopy() should preventDefault() only when it handles the copy event itself.

This issue causes an issue in read-only quill viewer where you cannot copy the entire text when you select it via mouse triple-click.

You can observe the issue on the ngx-quill official examples page:

1. Go to https://killercodemonkey.github.io/ngx-quill-example/
2. Scroll to the View format: object example.
3. Triple-click the "Hello World!" text.
4. Ctrl+C, Ctrl+V.
5. Hello World wasn't copied...

[anisabboud]

Just found out that @conlanpatrek already reported this issue in January: #4572, and created a 1-line PR to fix it: #4573.

Same findings: e.preventDefault(); in onCaptureCopy() needs to move two lines down.

Another same bug report: #4356.

[conlanpatrek]

@anisabboud your ticket is so much easier to read than mine. Just a heads up: there hasn't been a commit to the main branch for seven months, unfortunately.

But there is a workaround where you monkeypatch out the clipboard module copy handler entirely. I've been doing this with read-only quills, and it works well.

Lmk if you want implementation details.