Nav - SaveableNavStack
#2439
Nav - SaveableNavStack
#2439
Conversation
|
|
||
| public data class Record( | ||
| override val screen: Screen, | ||
| val args: Map<String, Any?> = emptyMap(), |
There was a problem hiding this comment.
I don't see the args being used in the full
prototype, what are these for? 🤔
There was a problem hiding this comment.
It's a hold over from the current backstack. But yaa should just remove it, its not in the interface.
| override val forwardItems: Iterable<Record> | ||
| get() = entries.subList(0, currentIndex).asReversed() | ||
|
|
||
| override val backwardItems: Iterable<Record> | ||
| get() = entries.subList(currentIndex + 1, entries.size) |
There was a problem hiding this comment.
These have no checks for the currentIndex
being within the limits of the entries size,
is that a concern here?
Eg. you could pass
entries = [A, B, C],
currentIndex = 3
and this would crash with IllegalArgumentException
There was a problem hiding this comment.
currentIndex is managed internally by SaveableNavStack and there are bounds checks before its ever mutated. For SaveableNavStackList here, its only ever visible to SaveableNavStack or the internal Saver.
| // Can't go backward anymore | ||
| assertFalse(navStack.backward()) |
There was a problem hiding this comment.
Should this also verify that the current record
has not changed when it can't go back anymore?
| // Can't go backward anymore | |
| assertFalse(navStack.backward()) | |
| // Can't go backward anymore | |
| assertFalse(navStack.backward()) | |
| assertEquals(TestScreen.RootAlpha, navStack.currentRecord?.screen) |
| // Can't go forward anymore | ||
| assertFalse(navStack.forward()) |
There was a problem hiding this comment.
Similarly here:
| // Can't go forward anymore | |
| assertFalse(navStack.forward()) | |
| // Can't go forward anymore | |
| assertFalse(navStack.forward()) | |
| assertEquals(TestScreen.ScreenC, navStack.currentRecord?.screen) |
Changes
NavStackfrom AddNavStack#2418Demo
Screen_recording_20251119_170905.mp4