Skip to content

Use JSON column type. #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sinaso wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use JSON column type. #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/core/src/main/scala/com.snowplowanalytics/iglu.schemaddl/bigquery/Suggestion.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@ object Suggestion {
def finalSuggestion(schema: Schema, required: Boolean): String => Field =
schema.`type` match {
case Some(jsonType) if jsonType.nullable =>
name => Field(name, Type.String, Mode.Nullable)
name => Field(name, Type.Json, Mode.Nullable)
case _ =>
name => Field(name, Type.String, Mode.required(required))
name => Field(name, Type.Json, Mode.required(required))
}

val suggestions: List[Suggestion] = List(
Expand Down
2 changes: 1 addition & 1 deletion modules/core/src/main/scala/com.snowplowanalytics/iglu.schemaddl/bigquery/Type.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ object Type {
case object Date extends Type
case object DateTime extends Type
case object Timestamp extends Type
case object Json extends Type
case class Record(fields: List[Field]) extends Type
}