Skip to content

Conversation

@psandana
Copy link

patch crate is unmaintained: uniphil/patch-rs#29

Project has been forked, and a new version with fixes has been created: https://github.com/gitpatch-rs/gitpatch

gitpatch version 0.7.1 is a direct replacement of patch version 0.7.0. Thus, no major changes are required.

@sourcefrog
Copy link
Owner

sourcefrog commented Apr 16, 2025 via email

@psandana
Copy link
Author

psandana commented Apr 16, 2025

Thanks, Also, I think I added a workaround for the "binary files differ" failure, which should be removed as it will no longer be necessary. Martin

There are more issues than the first one. Like this one: uniphil/patch-rs#24.

@sourcefrog
Copy link
Owner

sourcefrog commented Apr 16, 2025 via email

@sourcefrog sourcefrog self-assigned this Apr 21, 2025
@sourcefrog
Copy link
Owner

Specifically 78b7e31 could be partially reverted, leaving the test in place, and the changelog entry.

@psandana
Copy link
Author

@sourcefrog maybe I misunderstood. Do you want me to do these changes on this PR?

Specifically 78b7e31 could be partially reverted, leaving the test in place, and the changelog entry.

@sourcefrog
Copy link
Owner

If you can do it that would be great

@psandana
Copy link
Author

@sourcefrog I partially reverted 78b7e31. Is anything left? :)

@sourcefrog
Copy link
Owner

Thanks, removal of the workaround looks good.

Let's wait and see about patch vs gitpatch in uniphil/patch-rs#29 (comment). No need to bifurcate if upstream is actually still maintained.

@sourcefrog
Copy link
Owner

I just looked at this again in the context of fixing #547, where I hit gitpatch-rs/gitpatch#4.

At the moment it's unclear to me whether patch-rs or gitpatch is going to be better maintained. There is a PR gitpatch-rs/gitpatch#5 to fix that bug but it's been open for a few months. Both libraries have issues open asking about maintenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants