Enforce RunAtLoad and remove KeepAlive (#2795)

Overriding KeepAlive before actually implies RunAtLoad is true but we were setting RunAtLoad to false which is conflicting. In any case we don't want to restart the job if it crashes, and we want to run Updater when the job is loaded.

Author: zorgiepoo

InstallerLauncher/SUInstallerLauncher.m

@@ -86,8 +86,7 @@ - (BOOL)submitProgressToolAtPath:(NSString *)progressToolPath withHostBundle:(NS
         jobDictionary[@"Label"] = label;
         jobDictionary[@"ProgramArguments"] = arguments;
         jobDictionary[@"EnableTransactions"] = @NO;
-        jobDictionary[@"KeepAlive"] = @{@"SuccessfulExit" : @NO};
-        jobDictionary[@"RunAtLoad"] = @NO;
+        jobDictionary[@"RunAtLoad"] = @YES;
         jobDictionary[@"Nice"] = @0;
         jobDictionary[@"ProcessType"] = @"Interactive";
         jobDictionary[@"LaunchOnlyOnce"] = @YES;
@@ -284,7 +283,7 @@ - (SUInstallerLauncherStatus)submitInstallerAtPath:(NSString *)installerPath wit
             }
         }
 
-        NSDictionary *jobDictionary = @{@"Label" : label, @"ProgramArguments" : arguments, @"EnableTransactions" : @NO, @"KeepAlive" : @{@"SuccessfulExit" : @NO}, @"RunAtLoad" : @NO, @"Nice" : @0, @"ProcessType": @"Interactive", @"LaunchOnlyOnce": @YES, @"MachServices" : @{SPUInstallerServiceNameForBundleIdentifier(hostBundleIdentifier) : @YES, SPUProgressAgentServiceNameForBundleIdentifier(hostBundleIdentifier) : @YES}};
+        NSDictionary *jobDictionary = @{@"Label" : label, @"ProgramArguments" : arguments, @"EnableTransactions" : @NO, @"RunAtLoad" : @YES, @"Nice" : @0, @"ProcessType": @"Interactive", @"LaunchOnlyOnce": @YES, @"MachServices" : @{SPUInstallerServiceNameForBundleIdentifier(hostBundleIdentifier) : @YES, SPUProgressAgentServiceNameForBundleIdentifier(hostBundleIdentifier) : @YES}};
 
         CFErrorRef submitError = NULL;
 #pragma clang diagnostic push