change plugins keyfile path to XDG Base Directory spec #9925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f321x
force-pushed
the
change_plugin_keyfile_path
branch
from
4951e5a to
05ad6bd
Compare
changes the plugins keyfile to either XDG_CONFIG_HOME/electrum/plugins_key, or if empty to HOME/.config/electrum/plugins_key or if HOME is not set either (which should not happen in practice), to /etc/electrum/plugins_key. Also adds a `bring_to_front()` call after installing external plugin so the PluginsDialog is brought back in front.
f321x
force-pushed
the
change_plugin_keyfile_path
branch
from
05ad6bd to
a436740
Compare
SomberNight
reviewed
Jun 11, 2025
Comment on lines
+388
to
389
| sh_command = f"mkdir -p {base_dir_path} && " + sh_command | ||
| commands = ['pkexec', 'sh', '-c', sh_command] |
Member
There was a problem hiding this comment.
What if base_dir_path contains whitespaces or quotes? Previously we used a hardcoded path but now with changing to reading env vars (XDG_CONFIG_HOME and `HOME), anything is game.
See e.g. https://docs.python.org/3/library/shlex.html for escaping stuff.
Member
|
I am not expert enough to tell whether this is safe. It seems to me that the permissions/owner of a file located in a user-owned directory might be less restricted than in a root owned directory. I think it is safer to postpone this for now. There might be other ways to address #9922 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes the plugins keyfile to either
XDG_CONFIG_HOME/electrum/plugins_key,
or if empty to HOME/.config/electrum/plugins_key
or if HOME is not set either (which should not happen in practice), to /etc/electrum/plugins_key.
Also adds a
bring_to_front()call after installing external plugin so the PluginsDialog is raised back in front.see: https://specifications.freedesktop.org/basedir-spec/latest/
fixes #9922