Simplify secrets && scp

Author: ericbottard

.github/workflows/eric-continuous-integration.yml

@@ -16,8 +16,8 @@ concurrency:
 jobs:
   build-all:
     name: Build all modules
-    runs-on: ubuntu-latest
     if: ${{ github.repository_owner == 'spring-projects' }}
+    runs-on: ubuntu-latest
     steps:
       - name: Checkout source code
         uses: actions/checkout@v4
@@ -56,9 +56,9 @@ jobs:
 
   test-ollama:
     name: Test Ollama
+    if: ${{ github.repository_owner == 'spring-projects' }}
     runs-on: ubuntu-latest
     needs: build-all
-    if: ${{ github.repository_owner == 'spring-projects' }}
     services:
       ollama:
         image: ollama/ollama:latest
@@ -110,9 +110,9 @@ jobs:
 
   test-openai:
     name: Test OpenAI
+    if: ${{ github.repository_owner == 'spring-projects' }}
     runs-on: ubuntu-latest
     needs: build-all
-    if: ${{ github.repository_owner == 'spring-projects' }}
     steps:
       - name: Checkout source code
         uses: actions/checkout@v4
@@ -155,9 +155,9 @@ jobs:
 
   test-remaining:
     name: Test Remaining (MCP, Google GenAI, Chroma, PgVector)
+    if: ${{ github.repository_owner == 'spring-projects' }}
     runs-on: ubuntu-latest
     needs: build-all
-    if: ${{ github.repository_owner == 'spring-projects' }}
     steps:
       - name: Checkout source code
         uses: actions/checkout@v4
@@ -200,9 +200,9 @@ jobs:
 
   generate-javadocs:
     name: Generate and upload javadocs
+    if: ${{  github.repository_owner == 'spring-projects'  && github.event_name != 'schedule'}}
     runs-on: ubuntu-latest
     needs: [build-all, test-ollama, test-openai, test-remaining]
-    if: ${{ github.repository_owner == 'spring-projects' && github.event_name != 'schedule'}}
     steps:
       - name: Checkout source code
         uses: actions/checkout@v4
@@ -229,31 +229,23 @@ jobs:
         run: echo PROJECT_VERSION=$(./mvnw help:evaluate -Dexpression=project.version --quiet -DforceStdout) >> $GITHUB_ENV
 
       - name: Setup SSH key
-        env:
-          DOCS_SSH_KEY: ${{ secrets.DOCS_SSH_KEY }}
-          DOCS_SSH_HOST_KEY: ${{ secrets.DOCS_SSH_HOST_KEY }}
         run: |
           mkdir "$HOME/.ssh"
-          echo "$DOCS_SSH_KEY" > "$HOME/.ssh/key"
+          echo "${{ secrets.DOCS_SSH_KEY }}" > "$HOME/.ssh/key"
           chmod 600 "$HOME/.ssh/key"
-          echo "$DOCS_SSH_HOST_KEY" > "$HOME/.ssh/known_hosts"
+          echo "${{ secrets.DOCS_SSH_HOST_KEY }}" > "$HOME/.ssh/known_hosts"
 
       - name: Deploy docs
-        env:
-          DOCS_HOST: ${{ secrets.DOCS_HOST }}
-          DOCS_PATH: ${{ secrets.DOCS_PATH }}
-          DOCS_USERNAME: ${{ secrets.DOCS_USERNAME }}
-        working-directory: target/site/apidocs
         run: |
-          ssh -i $HOME/.ssh/key $DOCS_USERNAME@$DOCS_HOST "cd $DOCS_PATH && mkdir -p $PROJECT_VERSION"
-          scp -i $HOME/.ssh/key -r api $DOCS_USERNAME@$DOCS_HOST:$DOCS_PATH/$PROJECT_VERSION
+          ssh -i $HOME/.ssh/key ${{ secrets.DOCS_USERNAME }}@${{ secrets.DOCS_HOST }} "cd ${{ secrets.DOCS_PATH }} && mkdir -p $PROJECT_VERSION"
+          scp -i $HOME/.ssh/key -r target/site/apidocs ${{ secrets.DOCS_USERNAME }}@${{ secrets.DOCS_HOST }}:${{ secrets.DOCS_PATH }}/$PROJECT_VERSION
 
 
   deploy-artifactory:
     name: Deploy to Artifactory
     runs-on: ubuntu-latest
     needs: [build-all, test-ollama, test-openai, test-remaining]
-    if: ${{ github.repository_owner == 'spring-projects' && github.event_name != 'schedule' }}
+    if: ${{  github.repository_owner == 'spring-projects' && github.event_name != 'schedule' }}
     steps:
       - name: Checkout source code
         uses: actions/checkout@v4