Fix bugs in client code where next cursor param is sent in request body instead of as query param

Author: jsklan

.fernignore

@@ -6,4 +6,9 @@ test/
 .github/workflows
 README.md
 lib/square/file_param.rb
-custom.gemfile.rb
+custom.gemfile.rb
+
+# Pagination is currently broken for endpoints where the page token is not submitted via a query param
+# Manually fixed pagination bugs in:
+lib/square/inventory/client.rb
+lib/square/transfer_orders/client.rb

lib/square/inventory/client.rb

@@ -173,9 +173,9 @@ def batch_get_changes(request_options: {}, **params)
         Square::Internal::CursorItemIterator.new(
           cursor_field: :cursor,
           item_field: :changes,
-          initial_cursor: _query[:cursor]
+          initial_cursor: params[:cursor]
         ) do |next_cursor|
-          _query[:cursor] = next_cursor
+          params[:cursor] = next_cursor
           _request = Square::Internal::JSON::Request.new(
             base_url: request_options[:base_url] || Square::Environment::PRODUCTION,
             method: "POST",
@@ -214,9 +214,9 @@ def batch_get_counts(request_options: {}, **params)
         Square::Internal::CursorItemIterator.new(
           cursor_field: :cursor,
           item_field: :counts,
-          initial_cursor: _query[:cursor]
+          initial_cursor: params[:cursor]
         ) do |next_cursor|
-          _query[:cursor] = next_cursor
+          params[:cursor] = next_cursor
           _request = Square::Internal::JSON::Request.new(
             base_url: request_options[:base_url] || Square::Environment::PRODUCTION,
             method: "POST",

lib/square/transfer_orders/client.rb

@@ -64,9 +64,9 @@ def search(request_options: {}, **params)
         Square::Internal::CursorItemIterator.new(
           cursor_field: :cursor,
           item_field: :transfer_orders,
-          initial_cursor: _query[:cursor]
+          initial_cursor: params[:cursor]
         ) do |next_cursor|
-          _query[:cursor] = next_cursor
+          params[:cursor] = next_cursor
           _request = Square::Internal::JSON::Request.new(
             base_url: request_options[:base_url] || Square::Environment::PRODUCTION,
             method: "POST",