Fix remaining iterator test discrepancies. Fix pagination access pattern to not use .to_a

Author: jsklan

test/square/integration/client_tests/test_catalog.rb

@@ -10,22 +10,23 @@
   def delete_all_catalog_objects(client)
     catalog_objects_resp = client.catalog.list
     refute_nil catalog_objects_resp
-    assert_equal catalog_objects_resp.class, Square::Types::ListCatalogResponse
+    assert_equal Square::Internal::CursorItemIterator, catalog_objects_resp.class
     object_ids = []
-    
-    catalog_objects_resp.data.each do |catalog_object|
+
+    # Iterate using the iterator pattern
+    catalog_objects_resp.each do |catalog_object|
       next unless catalog_object.id
-      
+
       object_ids << catalog_object.id
-      
+
       next unless catalog_object.respond_to?(:item_data)
-      
+
       variation = catalog_object.item_data&.variations&.first
       next unless variation&.id
-      
+
       object_ids << variation.id
     end
-    
+
     _batch_delete_request = Square::Catalog::Types::BatchDeleteCatalogObjectsRequest.new(
       object_ids: object_ids
     )
@@ -302,7 +303,14 @@ def get_test_file
       number_of_pages = 0
       catalog_objects_resp = client.catalog.list
       number_of_pages += 1
-      assert_equal MAX_CATALOG_PAGE_SIZE, catalog_objects_resp.data.length
+
+      # Count items in first page using iterator
+      items = []
+      catalog_objects_resp.each do |item|
+        items << item
+        break if items.length >= MAX_CATALOG_PAGE_SIZE
+      end
+      assert_equal MAX_CATALOG_PAGE_SIZE, items.length
 
       while catalog_objects_resp.has_next_page?
         sleep(1) # Wait between page requests
@@ -447,9 +455,15 @@ def get_test_file
 
       response = client.catalog.list
       refute_nil response
-      assert_equal response.class, Square::Types::ListCatalogResponse
+      assert_equal Square::Internal::CursorItemIterator, response.class
+
+      # Count items using iterator
+      count = 0
+      response.each do |_item|
+        count += 1
+      end
 
-      puts "response items_count=#{response.data&.length || 0}" if verbose?
+      puts "response items_count=#{count}" if verbose?
     end
   end
 

test/square/integration/client_tests/test_customers_groups.rb

@@ -43,11 +43,16 @@ def delete_test_customer_group(group_id)
       list_response = client.customers.groups.list
       refute_nil list_response
       assert_equal Square::Internal::CursorItemIterator, list_response.class
-      groups = list_response.to_a
+
+      # Iterate using the iterator pattern
+      groups = []
+      list_response.each do |group|
+        groups << group
+      end
       refute_nil groups
       assert groups.length > 0
 
-      puts "list_response #{groups}" if verbose?
+      puts "list_response groups_count=#{groups.length}" if verbose?
 
       # Cleanup
       delete_test_customer_group(response.group.id)

test/square/integration/client_tests/test_customers_segments.rb

@@ -9,18 +9,31 @@
       response = client.customers.segments.list
       refute_nil response
       assert_equal Square::Internal::CursorItemIterator, response.class
-      # Iterator wraps the response, we need to access the first page to get segments
-      refute_nil response.to_a
 
-      puts "response #{response.to_a}" if verbose?
+      # Iterate using the iterator pattern
+      segments = []
+      response.each do |segment|
+        segments << segment
+      end
+
+      puts "response segments_count=#{segments.length}" if verbose?
     end
   end
 
   describe "#get" do
     it "should retrieve a customer segment" do
+
       list_response = client.customers.segments.list
-      segments = list_response.to_a
-      segment_id = segments.first.id
+      # Get first segment using iterator
+      first_segment = nil
+      list_response.each do |segment|
+        first_segment = segment
+        break
+      end
+
+      skip "No segments available to test" if first_segment.nil?
+
+      segment_id = first_segment.id
 
       _request = Square::Customers::Segments::Types::GetSegmentsRequest.new(
         segment_id: segment_id

test/square/integration/client_tests/test_inventory.rb

@@ -21,8 +21,15 @@
 
       response = client.inventory.batch_get_changes(**_request.to_h)
       refute_nil response
-      assert_equal response.class, Square::Types::BatchGetInventoryChangesResponse
-      puts "response #{response.to_h}" if verbose?
+      assert_equal Square::Internal::CursorItemIterator, response.class
+
+      # Iterate using the iterator pattern
+      changes = []
+      response.each do |change|
+        changes << change
+      end
+
+      puts "response changes_count=#{changes.length}" if verbose?
     end
   end
 end

test/square/integration/client_tests/test_merchants.rb

@@ -6,8 +6,12 @@
   before do
     # Get first merchant ID
     merchant_response = client.merchants.list
-    merchants = merchant_response.to_a
-    @merchant_id = merchants.first.id
+    first_merchant = nil
+    merchant_response.each do |merchant|
+      first_merchant = merchant
+      break
+    end
+    @merchant_id = first_merchant.id
   end
 
   describe "#list" do
@@ -16,11 +20,16 @@
       response = client.merchants.list
       refute_nil response
       assert_equal Square::Internal::CursorItemIterator, response.class
-      merchants = response.to_a
+
+      # Iterate using the iterator pattern
+      merchants = []
+      response.each do |merchant|
+        merchants << merchant
+      end
       refute_nil merchants
       assert merchants.length > 0
 
-      puts "response #{merchants}" if verbose?
+      puts "response merchants_count=#{merchants.length}" if verbose?
     end
   end
 

test/square/integration/client_tests/test_payments.rb

@@ -32,11 +32,16 @@ def create_sample_payment
       response = client.payments.list
       refute_nil response
       assert_equal Square::Internal::CursorItemIterator, response.class
-      payments = response.to_a
+
+      # Iterate using the iterator pattern
+      payments = []
+      response.each do |payment|
+        payments << payment
+      end
       refute_nil payments
       assert payments.length > 0
 
-      puts "response #{payments}" if verbose?
+      puts "response payments_count=#{payments.length}" if verbose?
     end
   end
 

test/square/integration/client_tests/test_refunds.rb

@@ -47,11 +47,16 @@
       puts "request #{_request.to_h}" if verbose?
 
       response = client.refunds.list
-      refunds = response.to_a
+
+      # Iterate using the iterator pattern
+      refunds = []
+      response.each do |refund|
+        refunds << refund
+      end
       refute_nil refunds
       assert refunds.length > 0
 
-      puts "response #{refunds}" if verbose?
+      puts "response refunds_count=#{refunds.length}" if verbose?
     end
   end