use exit-code for AnalyzeApplication (#11)

Co-authored-by: Markus Staab <[email protected]>

Author: staabm

lib/AnalyzeApplication.php

@@ -6,9 +6,14 @@
 
 final class AnalyzeApplication
 {
+    const EXIT_SUCCESS = 0;
+    const EXIT_ERROR = 1;
 
     /**
      * @param ResultPrinter::FORMAT_* $format
+     *
+     * @return self::EXIT_*
+     *
      * @throws \Safe\Exceptions\FilesystemException
      */
     public function start(string $glob, string $format): int
@@ -34,7 +39,10 @@ public function start(string $glob, string $format): int
             $this->printResult($format, $isFirst, $isLast, $stream);
         }
 
-        return 0;
+        if ($numBaselines > 0) {
+            return self::EXIT_SUCCESS;
+        }
+        return self::EXIT_ERROR;
     }
 
     public function help(): void

tests/AnalyzeApplicationTest.php

@@ -12,7 +12,7 @@ function testTextPrinting():void
         $app = new AnalyzeApplication();
 
         ob_start();
-        $app->start(__DIR__ . '/fixtures/all-in.neon', ResultPrinter::FORMAT_TEXT);
+        $exitCode = $app->start(__DIR__ . '/fixtures/all-in.neon', ResultPrinter::FORMAT_TEXT);
         $rendered = ob_get_clean();
 
         $rendered = str_replace(__DIR__, '', $rendered);
@@ -24,14 +24,15 @@ function testTextPrinting():void
 PHP;
 
         $this->assertSame($expected, $rendered);
+        $this->assertSame(0, $exitCode);
     }
 
     function testJsonPrinting():void
     {
         $app = new AnalyzeApplication();
 
         ob_start();
-        $app->start(__DIR__ . '/fixtures/all-in.neon', ResultPrinter::FORMAT_JSON);
+        $exitCode = $app->start(__DIR__ . '/fixtures/all-in.neon', ResultPrinter::FORMAT_JSON);
         $rendered = ob_get_clean();
 
         $rendered = str_replace(trim(json_encode(__DIR__), '"'), '', $rendered);
@@ -41,5 +42,18 @@ function testJsonPrinting():void
 PHP;
 
         $this->assertSame($expected, $rendered);
+        $this->assertSame(0, $exitCode);
+    }
+
+    function testNoMatchingGlob():void
+    {
+        $app = new AnalyzeApplication();
+
+        ob_start();
+        $exitCode = $app->start('this/file/does/not/exist*baseline.neon', ResultPrinter::FORMAT_TEXT);
+        $rendered = ob_get_clean();
+
+        $this->assertSame('', $rendered);
+        $this->assertSame(1, $exitCode);
     }
 }