You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit bbf3751
Browse filesBrowse the repository at this point in the historyBrowse files
fix: Encode user ids and names as single URL path segments in UIF (#909)
* fix: Encode user ids and names as single URL path segments in UIF
The Keycloak and Entra backends joined request-supplied user ids and
names onto the base URL as text, so `/`, `?`, `#` and `..` in them
changed which URL was requested. Both now append them as one
percent-encoded path segment through `append_path_segments`, and the
Keycloak backend sends the username as a query parameter.
An empty, `.` or `..` segment and one containing a line break are
rejected with `400`, as the url crate would drop or strip them and look
up a different user.
A Keycloak `rootPath` without a trailing slash is now kept, which
`Url::join` dropped.
* chore: Regenerate Cargo.nix
* chore: Bump rustls-webpki to 0.103.16
* chore: Use UrlExt::join_safe from stackable-operator
* chore: Upgrade serde-saphyr
* chore: Add ConstructUserGroupsUrl error case
* test: Remove unnecessary test case
* chore: Remove the dependency to percent-encoding
* test(keycloak-user-info): Serve Keycloak below a subpath
* chore: Improve comments
---------
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
Copy file name to clipboardExpand all lines: CHANGELOG.md
+10Lines changed: 10 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -92,6 +92,15 @@ All notable changes to this project will be documented in this file.
92
92
See [our internal issue](https://github.com/stackabletech/hdfs-operator/issues/626) and [the fix](https://github.com/kube-rs/kube/pull/2042) for details ([#871]).
93
93
- The reconciler now applies resources and derives the cluster status in discrete
94
94
apply and update_status steps for the `opa_controller` ([#872]).
95
+
- The user-info-fetcher Entra backend now encodes the user id and the username as a single URL path
96
+
segment. An empty, `.` or `..` id or username, or one containing a line break, is rejected with
97
+
`400` ([#909]).
98
+
- The user-info-fetcher Keycloak backend now encodes the user id as a single URL path segment, and
99
+
sends the username as a query parameter instead of appending it to the URL as text, so that a
100
+
username can no longer add or override search parameters. An empty, `.` or `..` id, or one
101
+
containing a line break, is rejected with `400` ([#909]).
102
+
- The user-info-fetcher Keycloak backend no longer drops a configured `rootPath` from the URLs it
103
+
requests, so a Keycloak served below a sub-path, like `/auth`, can now be reached ([#909]).
0 commit comments