checkpoint

Author: pcj

language/starlarkbundle/language.go

@@ -253,7 +253,7 @@ func (ext *starlarkBundleLang) getModuleDependencyRepoName(repo string) (string,
 		return mappedRepo, true
 	} else {
 		ext.logf("  unknown module dependency: %q (known deps: %v)", repo, ext.moduleDeps)
-		log.Fatalf("unknown module dependency: %q", repo)
+		// log.Fatalf("unknown module dependency: %q", repo)
 		return repo, false
 	}
 }

language/starlarkbundle/starlark_bundle.go

@@ -33,6 +33,7 @@ import (
 
 const (
 	starlarkBundleKind = "starlark_bundle"
+	starlarkBundleName = "docs"
 )
 
 var starlarkBundleKindInfo = map[string]rule.KindInfo{
@@ -48,7 +49,7 @@ var starlarkBundleLoadInfo = rule.LoadInfo{
 }
 
 func starlarkBundleRule() (*rule.Rule, []string) {
-	r := rule.NewRule(starlarkBundleKind, starlarkBundleKind)
+	r := rule.NewRule(starlarkBundleKind, starlarkBundleName)
 
 	r.SetAttr("visibility", []string{"//visibility:public"})
 

language/starlarkbundle/starlark_library.go

@@ -367,12 +367,6 @@ func checkInternalVisibility(rel, visibility string) string {
 	return visibility
 }
 
-func sanitizeName(name string) string {
-	name = strings.ReplaceAll(name, "/", "_")
-	name = strings.ReplaceAll(name, "+", "_")
-	return name
-}
-
 // deduplicateAndSort removes duplicate entries and sorts the list
 func deduplicateAndSort(in []string) (out []string) {
 	if len(in) == 0 {