Skip to content

Conversation

@surajdm123
Copy link
Contributor

Context

This PR adds the missing unit test case for XMLTokener.

Test Plan

mvn -Dtest=XMLTokenerTest test

...
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.json.junit.XMLTokenerTest
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.027 s -- in org.json.junit.XMLTokenerTest
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
Screenshot 2025-07-03 at 1 25 05 AM

Next Steps

  1. Add more missing test cases to make this codebase more resilient.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 3, 2025

@stleary
Copy link
Owner

stleary commented Jul 4, 2025

What problem does this code solve?
Improves XMLTokener test coverage from 85% to 87%

Does the code still compile with Java6?
Yes

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No, new unit tests were added

Was any code refactored in this commit?
No

Review status
APPROVED

Starting 3-day comment window

@surajdm123
Copy link
Contributor Author

@stleary
Looks like you forgot to add the label. Can you please check?

Also when do you usually merge the PR?

@stleary
Copy link
Owner

stleary commented Jul 4, 2025

3 days is the usual wait time. Don't often get comments, but it has happened.

@stleary stleary merged commit 1eed44a into stleary:master Jul 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants