https://issues.redhat.com/browse/ACM-25181 #8339
+650
−308
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,181 @@ | ||||||
| [#enable-gitops-addon-with-argocd] | ||||||
| = Enabling {gitops} add-on with _ArgoCD_ agent | ||||||
|
|
||||||
| Enable the {gitops-short} add-on for `Advanced` pull model with the `ArgoCD` agent to get detailed statuses on the health of your hub clusters and to simplify your cluster management processes. To enable a GitOps add-on with the `ArgoCD` agent, complete the following sections: | ||||||
|
||||||
| Enable the {gitops-short} add-on for `Advanced` pull model with the `ArgoCD` agent to get detailed statuses on the health of your hub clusters and to simplify your cluster management processes. To enable a GitOps add-on with the `ArgoCD` agent, complete the following sections: | |
| Enable the {gitops-short} add-on for `Advanced` pull model with the `ArgoCD` agent to get detailed statuses on the health of your Application. To enable a GitOps add-on with the `ArgoCD` agent, complete the following sections: |
Contributor
There was a problem hiding this comment.
Throughout the doc, these are complete sentences. We would be changing that with this prereq list. Usually:
You need x
or
You have X.
Contributor
There was a problem hiding this comment.
I think this is conref-ed in our docs--please check; please check on all product names internally and check the guidance if we don't have anything for this. Check all OCP and GitOps instances for conref and naming.
Contributor
There was a problem hiding this comment.
please never use under, this can alienate a nonsighted user. We go over this in our internal doc very clearly: https://stolostron.github.io/rhacm-docs/accessibility
Further we have this on the checklist: https://stolostron.github.io/rhacm-docs/checklist (directional language)
Contributor
There was a problem hiding this comment.
Remove the possessive here and rewrite that line; see the IBM style guide about possessive.
"its" is also not capitalized, but is a start a new sentence, I think?
Contributor
There was a problem hiding this comment.
The controller .... creates (add the s to make subject/predicate agree,
Contributor
There was a problem hiding this comment.
They are for Argo CD to understand what clusters are imported.
Argo CD by default does not understand ACM's ManagedClusters.
This progress is equivalent of: importing all the ACM's ManagedClusters (selected by the Placement) into Argo CD.
Contributor
There was a problem hiding this comment.
Sometimes Argo CD is coded, see above examples, and sometimes not.
jc-berger marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
jc-berger marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
inputting?
We normally keep it simple:
Add the following YAML to create ___
Create ___ by adding the following YAML.
Are they adding the entire sample and what from it matters to the user. We don't want to just give them a big sample and not explain it.
jc-berger marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
jc-berger marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
jc-berger marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
jc-berger marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
- Ready - GitOpsCluster is ready and all components are functioning correctly
- PlacementResolved - Placement reference resolved and managed clusters retrieved
- ClustersRegistered - Managed clusters successfully registered with ArgoCD server
- AddOnDeploymentConfigsReady - AddOnDeploymentConfigs created for all managed clusters (GitOps addon)
- ManagedClusterAddOnsReady - ManagedClusterAddons created/updated for all managed clusters (GitOps addon)
- AddOnTemplateReady - Dynamic AddOnTemplate created for ArgoCD agent mode (ArgoCD agent only)
- ArgoCDAgentPrereqsReady - ArgoCD agent prerequisites are set up (RBAC, Redis secret, JWT secret, server discovery)
- CertificatesReady - ArgoCD agent TLS certificates (CA, Principal, Resource Proxy) are signed and ready
- ManifestWorksApplied - CA certificates propagated to managed clusters via ManifestWorks (ArgoCD agent only)
Sorry, we added new conditions. Please see above for the full list.
Contributor
There was a problem hiding this comment.
I would take out learning here since they are heading to a task and not a concept and you are telling them to "complete" something?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| [#enable-gitops-addon-without-argocd] | ||
| = Enabling {gitops} add-on without the _ArgoCD_ agent | ||
|
|
||
| The `Basic` pull model does not include the `ArgoCD` agent, so it gives you a simpler setup for your hub cluster management and only gives you the necessary statuses of the health of your hub clusters. | ||
|
Contributor
There was a problem hiding this comment. Same with the GitOps name throughout, see where the conref needs to be used. |
||
|
|
||
| To enable a GitOps add-on without the `ArgoCD` agent, complete the following sections: | ||
|
|
||
| * <<prerequisites, Prerequisites>> | ||
| * <<create-gitopscluster-resource, Creating a _GitOpsCluster_ resource>> | ||
| * <<verify-installation, Verifying the installation>> | ||
| * <<additional-resources, Additional resources>> | ||
|
|
||
| [#prerequisites] | ||
| == Prerequisites | ||
|
Contributor
There was a problem hiding this comment. Same feedback. You tell them to "complete" this section in the line before, so I would go with different language, but either way these are complete sentences in most of the books. Ensure you have an {acm-short} hub cluster installed. |
||
|
|
||
| * {acm-short} hub cluster installed | ||
| * Managed clusters registered with {acm-short} | ||
| * OpenShift GitOps operator installed on the hub cluster | ||
| * A `Placement` resource to select target managed clusters | ||
| * `ManagedClusterSet` bound to the target namespace | ||
|
|
||
| [#create-gitopscluster-resource] | ||
| == Creating a `GitOpsCluster` resource | ||
|
|
||
| Instead of using an `ArgoCD` agent, you can install a `GitOpsCluster` resource. After you install a `GitOpsCluster` resource, its controller automatically creates the following resources for each managed cluster selected by the `Placement` policy: | ||
|
||
|
|
||
| * `AddOnDeploymentConfig` in the managed cluster namespace | ||
jc-berger marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| * `ManagedClusterAddOn` in the managed cluster namespace | ||
jc-berger marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| The {gitops} add-on deploys to each selected managed cluster and installs the following resources: | ||
|
|
||
| * OpenShift GitOps operator in the `openshift-gitops-operator` namespace | ||
| * Argo CD instance in the `openshift-gitops` namespace | ||
jc-berger marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| To create a `GitOpsCluster` resource, complete the following steps: | ||
|
|
||
| . On your hub cluster, create a `GitOpsCluster` resource to enable the {gitops} add-on: | ||
|
|
||
|
|
||
| + | ||
| [source,yaml] | ||
| ---- | ||
| apiVersion: apps.open-cluster-management.io/v1beta1 | ||
| kind: GitOpsCluster | ||
| metadata: | ||
| name: gitops-clusters | ||
| namespace: openshift-gitops | ||
| spec: | ||
| argoServer: | ||
| argoNamespace: openshift-gitops | ||
| placementRef: | ||
| kind: Placement | ||
| apiVersion: cluster.open-cluster-management.io/v1beta1 | ||
| name: all-openshift-clusters | ||
| namespace: openshift-gitops | ||
| gitopsAddon: | ||
| enabled: true | ||
| ---- | ||
|
|
||
| [#verify-installation] | ||
| == Verifying the installation | ||
|
|
||
| To verify the necessary installations and resources for successful deployment, complete the following steps: | ||
|
|
||
| . Verify that the `GitOpsCluster` resource has a status for successful deployment by running the following command: | ||
|
|
||
| + | ||
| [source,bash] | ||
| ---- | ||
| oc get gitopscluster gitops-clusters -n openshift-gitops -o yaml | ||
| ---- | ||
|
|
||
| . Verify that the GitOps add-on controller is working by running the following command: | ||
|
Contributor
There was a problem hiding this comment. This command and the following commands are meant to run on the managed cluster (where the addon is installed). |
||
|
|
||
| + | ||
| [source,bash] | ||
| ---- | ||
| oc get pods -n open-cluster-management-agent-addon | ||
| ---- | ||
|
|
||
| . Verify the OpenShift GitOps operator is working by running the following command: | ||
|
|
||
| + | ||
| [source,bash] | ||
| ---- | ||
| oc get pods -n openshift-gitops-operator | ||
| ---- | ||
|
|
||
| . Verify the Argo CD instance is working by running the following command: | ||
|
|
||
| + | ||
| [source,bash] | ||
| ---- | ||
| oc get pods -n openshift-gitops | ||
| ---- | ||
|
|
||
| [#additional-resources] | ||
| == Additional resources | ||
|
|
||
| Continue learning about the {gitops-short} add-on by completing xref:../gitops/gitops_manage_addon.adoc#manage-gitops-addon[Managing the {gitops} add-on]. | ||
|
Contributor
There was a problem hiding this comment. same with "learning" but you are sending them to a task to "complete" |
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback for the entire collection here:
This was a lot, great job. I think it's getting close to done.
Themes:
The YAML additions are missing details or specifics.
All of them are also missing the step to apply the command. I have shown this previously, but there are also examples in the doc if you need to see what I mean. We give them a sample to add, explain it a bit, then give them the command to apply.
Usually something like:
oc apply(check for sure)Couple other smaller things.