fix(cli): handle pagination without total metadata (#249)

Rather than rely on the self reported pages and totals which appears to
be inconsistent, we can instead infer if there are any remaining pages
by counting the results.

Resolves #238
Resolves #248

---------

Co-authored-by: Copilot <[email protected]>

Author: imranolas

packages/cli/src/commands/stories/actions.test.ts

@@ -270,6 +270,52 @@ describe('stories/actions', () => {
         );
       });
     });
+
+    it('should handle pagination when per_page and total are missing from response', async () => {
+      // Mock pages
+      const page1Stories = Array.from({ length: 100 }, (_, i) => ({
+        ...mockStories[0],
+        id: i + 1,
+        name: `Story ${i + 1}`,
+        uuid: `uuid-${i + 1}`,
+      }));
+      const page2Stories = Array.from({ length: 50 }, (_, i) => ({
+        ...mockStories[0],
+        id: i + 101,
+        name: `Story ${i + 101}`,
+        uuid: `uuid-${i + 101}`,
+      }));
+
+      // Override handler to simulate API without pagination metadata
+      server.use(
+        http.get('https://api.storyblok.com/v1/spaces/:spaceId/stories', ({ request }) => {
+          const url = new URL(request.url);
+          const page = Number.parseInt(url.searchParams.get('page') || '1', 10);
+
+          if (page === 1) {
+            // First page returns 100 stories (no per_page and total fields)
+            return HttpResponse.json({ stories: page1Stories });
+          }
+          else if (page === 2) {
+            // Second page returns 50 stories (less than per_page, indicating end)
+            return HttpResponse.json({ stories: page2Stories });
+          }
+          else {
+            // Third page returns empty array
+            return HttpResponse.json({ stories: [] });
+          }
+        }),
+      );
+
+      const result = await fetchStories(mockSpace);
+
+      // Should fetch all stories from both pages
+      expect(result).toHaveLength(150);
+      expect(result?.[0].id).toBe(1);
+      expect(result?.[99].id).toBe(100);
+      expect(result?.[100].id).toBe(101);
+      expect(result?.[149].id).toBe(150);
+    });
   });
 
   describe('fetchStoriesByComponent', () => {

packages/cli/src/commands/stories/actions.ts

@@ -19,14 +19,15 @@ export const fetchStories = async (
     const allStories: Story[] = [];
     let currentPage = 1;
     let hasMorePages = true;
+    const perPage = 100;
 
     while (hasMorePages) {
       // Extract filter_query params to handle them separately
       const { filter_query, ...restParams } = params || {};
 
       // Handle regular params with URLSearchParams
       const regularParams = new URLSearchParams({
-        ...objectToStringParams({ ...restParams, per_page: 100 }),
+        ...objectToStringParams({ ...restParams, per_page: perPage }),
         ...(currentPage > 1 && { page: currentPage.toString() }),
       }).toString();
 
@@ -39,16 +40,19 @@ export const fetchStories = async (
 
       const { data } = await client.get<{
         stories: Story[];
-        per_page: number;
-        total: number;
+        per_page?: number;
+        total?: number;
       }>(endpoint, {
       });
 
       allStories.push(...data.stories);
 
-      // Check if we have more pages to fetch
-      const totalPages = Math.ceil(data.total / data.per_page);
-      hasMorePages = currentPage < totalPages;
+      // Since per_page and total may not be available, check if we got fewer stories than requested
+      // If we got fewer stories than per_page, we've reached the end
+      hasMorePages = data.stories.length === perPage && data.stories.length > 0;
+      if (data.stories.length < perPage) {
+        break;
+      }
       currentPage++;
     }