Fix Content-Type for HTTP exceptions (#4037)

Co-authored-by: Thiago Bellini Ribeiro <[email protected]>

Author: mgorven

RELEASE.md

@@ -0,0 +1,4 @@
+Release type: patch
+
+Set Content-Type to `text/plain` for exceptions so that these are displayed
+correctly.

strawberry/chalice/views.py

@@ -82,6 +82,7 @@ def execute_request(self, request: Request) -> Response:
             return Response(
                 body=e.reason,
                 status_code=e.status_code,
+                headers={"Content-Type": "text/plain"},
             )
 
 

strawberry/channels/handlers/http_handler.py

@@ -240,7 +240,11 @@ async def handle(self, body: bytes) -> None:
             else:
                 assert_never(response)
         except HTTPException as e:
-            await self.send_response(e.status_code, e.reason.encode())
+            await self.send_response(
+                e.status_code,
+                e.reason.encode(),
+                headers=[(b"Content-Type", b"text/plain")],
+            )
 
 
 class GraphQLHTTPConsumer(

strawberry/django/views.py

@@ -164,6 +164,7 @@ def dispatch(
             return HttpResponse(
                 content=e.reason,
                 status=e.status_code,
+                content_type="text/plain",
             )
 
     def render_graphql_ide(self, request: HttpRequest) -> HttpResponse:
@@ -224,6 +225,7 @@ async def dispatch(  # pyright: ignore
             return HttpResponse(
                 content=e.reason,
                 status=e.status_code,
+                content_type="text/plain",
             )
 
     async def render_graphql_ide(self, request: HttpRequest) -> HttpResponse:

strawberry/flask/views.py

@@ -84,6 +84,7 @@ def dispatch_request(self) -> ResponseReturnValue:
             return Response(
                 response=e.reason,
                 status=e.status_code,
+                content_type="text/plain",
             )
 
     def render_graphql_ide(self, request: Request) -> Response:
@@ -117,6 +118,7 @@ async def dispatch_request(self) -> ResponseReturnValue:  # type: ignore
             return Response(
                 response=e.reason,
                 status=e.status_code,
+                content_type="text/plain",
             )
 
     async def render_graphql_ide(self, request: Request) -> Response:

strawberry/quart/views.py

@@ -145,6 +145,7 @@ async def dispatch_request(self, **kwargs: object) -> "ResponseReturnValue":
             return Response(
                 response=e.reason,
                 status=e.status_code,
+                content_type="text/plain",
             )
 
     async def create_streaming_response(

strawberry/sanic/views.py

@@ -138,15 +138,19 @@ async def post(self, request: Request) -> HTTPResponse:
         try:
             return await self.run(request)
         except HTTPException as e:
-            return HTTPResponse(e.reason, status=e.status_code)
+            return HTTPResponse(
+                e.reason, status=e.status_code, content_type="text/plain"
+            )
 
     async def get(self, request: Request) -> HTTPResponse:
         self.request = request
 
         try:
             return await self.run(request)
         except HTTPException as e:
-            return HTTPResponse(e.reason, status=e.status_code)
+            return HTTPResponse(
+                e.reason, status=e.status_code, content_type="text/plain"
+            )
 
     async def create_streaming_response(
         self,

tests/http/test_http.py

@@ -24,9 +24,17 @@ async def test_the_http_handler_uses_the_views_decode_json_method(
 
     response = await http_client.query(query="{ hello }")
     assert response.status_code == 200
+    assert response.headers["content-type"].split(";")[0] == "application/json"
 
     data = response.json["data"]
     assert isinstance(data, dict)
     assert data["hello"] == "Hello world"
 
     assert spy.call_count == 1
+
+
+async def test_exception(http_client: HttpClient, mocker):
+    response = await http_client.query(query="{ hello }", operation_name="wrong")
+    assert response.status_code == 400
+    assert response.headers["content-type"].split(";")[0] == "text/plain"
+    assert response.data == b'Unknown operation named "wrong".'