Skip to content

Commit 9df28d4

Browse files
tokokonielspardon
andauthored
fix: remove SHELL from devcontainer (#116)
Co-authored-by: Niels Pardon <[email protected]>
1 parent 5a76031 commit 9df28d4

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

.devcontainer/Dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
FROM mcr.microsoft.com/vscode/devcontainers/python:3.13
22
USER vscode
33
RUN curl -s "https://get.sdkman.io" | bash
4-
SHELL ["/bin/bash", "-c"]
5-
RUN source "/home/vscode/.sdkman/bin/sdkman-init.sh" && sdk install java 25-graalce
4+
RUN bash -c "source $HOME/.sdkman/bin/sdkman-init.sh && \
5+
sdk install java 25-graalce"
66
RUN mkdir -p ~/lib && cd ~/lib && curl -L -O http://www.antlr.org/download/antlr-4.13.2-complete.jar
7-
ENV ANTLR_JAR="~/lib/antlr-4.13.1-complete.jar"
7+
ENV ANTLR_JAR="~/lib/antlr-4.13.2-complete.jar"
88
# protoc 29.5 is the last version with protobuf python v5 which is compatible with protoletariat v3
99
RUN cd ~ && curl -LO https://github.com/protocolbuffers/protobuf/releases/download/v29.5/protoc-29.5-linux-x86_64.zip && \
1010
unzip protoc-29.5-linux-x86_64.zip -d ~/.local && \

.devcontainer/devcontainer.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@
22
"name": "substrait-python-devcontainer",
33
"build": {
44
"context": "..",
5-
"dockerfile": "Dockerfile",
6-
"options": ["--format=docker"]
5+
"dockerfile": "Dockerfile"
76
},
87

98
// Features to add to the dev container. More info: https://containers.dev/features.

0 commit comments

Comments
 (0)