fix test

Author: sdemagny

env.d/development/backend.e2e

@@ -32,3 +32,7 @@ EMAIL_BACKEND=django.core.mail.backends.console.EmailBackend
 
 # Debug
 DJANGO_DEBUG=True
+
+# Max recipients per message settings for E2E tests
+MAX_RECIPIENTS_PER_MESSAGE=200
+MAX_DEFAULT_RECIPIENTS_PER_MESSAGE=150

src/e2e/src/__tests__/message-max-recipients-admin.spec.ts

@@ -20,13 +20,13 @@ test.describe("Message Max Recipients Per Message", () => {
     await page.getByRole("heading", { name: "Maildomains management" }).waitFor({ state: "visible" });
 
     // Update max recipients per message
-    const tuneLimitsButton = page.getByRole('button', { name: 'tune Limits' });
+    const tuneLimitsButton = page.getByRole('button', { name: 'tune Settings' });
     await tuneLimitsButton.click();
     const maxRecipientsPerMessageInput = page.getByLabel("Maximum recipients per message");
-    await maxRecipientsPerMessageInput.fill("100");
+    await maxRecipientsPerMessageInput.fill("50");
     const saveButton = page.getByRole('button', { name: 'Save' });
     await saveButton.click();
-    await page.getByText('The domain limits have been').waitFor({ state: "visible" });
+    await page.getByText('The domain settings have been updated!').waitFor({ state: "visible" });
 
     // Go back to the maildomain list
     const backToMaildomainsButton = page.getByRole('link', { name: 'mail', exact: true });
@@ -43,42 +43,47 @@ test.describe("Message Max Recipients Per Message", () => {
     const helpText = await page.locator('text=/maximum.*recipients/i').textContent();
     const limitMatch = helpText?.match(/\d+/);
     const limit = limitMatch ? parseInt(limitMatch[0]) : null;
-    console.log(limitMatch);
-    console.log(limit);
-    expect(limit).toBe(100);
+    expect(limit).toBe(50);
   });
 
-  test("should super user can customize domain max recipients per message more than the global limit", async ({ page, browserName }) => {
-    // Get the current limit from help text
+  test("should reject domain limit exceeding global maximum", async ({ page, browserName }) => {
+    // Login as super_admin
     await page.goto("/");
     await signInKeycloakIfNeeded({ page, username: `super_admin.e2e.${browserName}` });
-    // Navigate to new message form
+
+    // Navigate to domain admin
     const moreOptionsButton = page.getByRole('button', { name: 'More options' });
     await moreOptionsButton.click();
     const manageMaildomainButton = page.getByRole('menuitem', { name: 'Domain admin' });
     await manageMaildomainButton.click();
     await page.waitForURL("/domain");
     await page.getByRole("heading", { name: "Maildomains management" }).waitFor({ state: "visible" });
-    // Update max recipients per message
-    const tuneLimitsButton = page.getByRole('button', { name: 'tune Limits' });
-    await tuneLimitsButton.click();
+
+    // Open settings modal
+    const tuneSettingsButton = page.getByRole('button', { name: 'tune Settings' });
+    await tuneSettingsButton.click();
     await page.waitForTimeout(50);
     const maxRecipientsPerMessageInput = page.getByLabel("Maximum recipients per message");
-    expect(maxRecipientsPerMessageInput).toBeVisible({ timeout: 5000 });
-    console.log(maxRecipientsPerMessageInput);
+    await expect(maxRecipientsPerMessageInput).toBeVisible({ timeout: 5000 });
+
+    // Store current value to verify it's unchanged after failed save
+    const initialValue = await maxRecipientsPerMessageInput.inputValue();
+
+    // Try to set a limit exceeding global maximum (200)
     await maxRecipientsPerMessageInput.fill("250");
     const saveButton = page.getByRole('button', { name: 'Save' });
     await saveButton.click();
     await page.getByText('The limit cannot exceed the global maximum of 200 recipients.').waitFor({ state: "visible" });
-    // close the modal
+
+    // Close the modal
     await page.getByRole('button', { name: 'close' }).click();
 
-    // check limit is still 100
-    await tuneLimitsButton.click();
+    // Verify the limit was not changed
+    await tuneSettingsButton.click();
     await page.waitForTimeout(50);
-    expect(maxRecipientsPerMessageInput).toBeVisible({ timeout: 5000 });
-    const inputValue = await maxRecipientsPerMessageInput.inputValue();
-    expect(parseInt(inputValue)).toBe(100);
+    await expect(maxRecipientsPerMessageInput).toBeVisible({ timeout: 5000 });
+    const finalValue = await maxRecipientsPerMessageInput.inputValue();
+    expect(finalValue).toBe(initialValue);
   });
 
   test("should domain admin can customize mailbox max recipients per message ", async ({ page, browserName }) => {

src/e2e/src/__tests__/message-max-recipients.spec.ts

@@ -27,7 +27,8 @@ test.describe("Message Recipients Limit", () => {
     const limitMatch = helpText?.match(/\d+/);
     expect(limitMatch).toBeTruthy();
     const limit = parseInt(limitMatch![0]);
-    expect(limit).toBe(100);
+    // FIXME: this is value set in message-max-recipients-admin.spec.ts
+    expect(limit).toBe(50);
   });
 
 });