fix: allow requested() in a command called from other server code - #17040
Open
kdelay wants to merge 2 commits into
Open
fix: allow requested() in a command called from other server code#17040kdelay wants to merge 2 commits into
kdelay wants to merge 2 commits into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/62fa98f27dd77f0c4e92432cc085e75e1680d929Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: b768d38 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17035.
requested()throws as soon as a command runs outside a/_app/remote/...request, e.g. when a+server.jshandler calls it. Since #15991is_in_remote_form_or_commandis set only by the remote endpoint, so "inside a command" means "the request arrived at that endpoint".The wrapper marks the context itself again, the way
query.bindsetsis_in_remote_query. Such a request has no client cache to update, sorequested()yields nothing andrefreshAll()is a no-op instead of throwing.#16968 replaces this flag and fixes the same regression on the way: on 8ff8bc6 the three tests here pass unchanged. If it lands first, keep the tests and drop the runtime change.
Testing
test:unit(the first new test fails without the fix),lint,check,prepublishOnly, and thetest-asyncremote suite.