Deprecate AbsolutePath.withPOSIX(path:)

Author: stevapple

Sources/TSCBasic/Path.swift

@@ -175,9 +175,9 @@ extension Path {
 
 /// Represents an absolute file system path, independently of what (or whether
 /// anything at all) exists at that path in the file system at any given time.
-/// An absolute path always starts with a `/` character, and holds a normalized
-/// string representation.  This normalization is strictly syntactic, and does
-/// not access the file system in any way.
+/// An absolute path always holds a normalized string representation.  This
+/// normalization is strictly syntactic, and does not access the file system
+/// in any way.
 ///
 /// The absolute path string is normalized by:
 /// - Collapsing `..` path components
@@ -197,7 +197,7 @@ public struct AbsolutePath: Path {
     /// Underlying type, based on SwiftSystem.
     public let filepath: FilePath
 
-    /// Public initializer with FilePath.
+    /// Public initializer with `FilePath``.
     public init(_ filepath: FilePath) {
 #if os(Windows)
         if filepath.isAbsolute {
@@ -220,6 +220,11 @@ public struct AbsolutePath: Path {
     /// not interpret leading `~` characters as home directory specifiers).
     /// The input string will be normalized if needed, as described in the
     /// documentation for AbsolutePath.
+    /// 
+    /// On Unix-like systems, an absolute path always starts with a `/`
+    /// character. Windows normally regards `/` as a relative root, but for
+    /// compatibility, system drive letter will be appended. Use
+    /// `try AbsolutePath(validating:)` to avoid such convention.
     public init(_ absStr: String) {
         self.init(FilePath(absStr))
     }
@@ -299,20 +304,6 @@ public struct AbsolutePath: Path {
 #endif
         }
     }
-
-    @available(*, deprecated, message: "use AbsolutePath(_:) directly")
-    public static func withPOSIX(path: String) -> AbsolutePath {
-#if os(Windows)
-        var filepath = FilePath(path)
-        precondition(filepath.root != nil)
-        if !filepath.isAbsolute {
-            filepath.root = root.filepath.root
-        }
-        return AbsolutePath(filepath)
-#else
-        return AbsolutePath(path)
-#endif
-    }
 }
 
 /// Represents a relative file system path.  A relative path never starts with

Sources/TSCBasic/PathShims.swift

@@ -29,7 +29,7 @@ public func resolveSymlinks(_ path: AbsolutePath) -> AbsolutePath {
     }
 
     return resolved.standardized.withUnsafeFileSystemRepresentation {
-        try! AbsolutePath(validating: String(cString: $0!))
+        AbsolutePath(String(cString: $0!))
     }
 #else
     let pathStr = path.pathString

Sources/TSCTestSupport/FileSystemExtensions.swift

@@ -25,7 +25,7 @@ extension InMemoryFileSystem {
         self.init()
 
         for (path, contents) in files {
-            let path = AbsolutePath.withPOSIX(path: path)
+            let path = AbsolutePath(path)
             try! createDirectory(path.parentDirectory, recursive: true)
             try! writeFileContents(path, bytes: contents)
         }
@@ -52,7 +52,7 @@ extension FileSystem {
         do {
             try createDirectory(root, recursive: true)
             for path in files {
-                let components = AbsolutePath.withPOSIX(path: path).components
+                let components = AbsolutePath(path).components
                 let path = root.appending(components: components)
                 try createDirectory(path.parentDirectory, recursive: true)
                 try writeFileContents(path, bytes: "")

Tests/TSCBasicTests/PathShimTests.swift

@@ -37,9 +37,9 @@ class WalkTests : XCTestCase {
       #if os(Android)
         let root = "/system"
         var expected = [
-            AbsolutePath.withPOSIX(path: "\(root)/usr"),
-            AbsolutePath.withPOSIX(path: "\(root)/bin"),
-            AbsolutePath.withPOSIX(path: "\(root)/xbin")
+            AbsolutePath("\(root)/usr"),
+            AbsolutePath("\(root)/bin"),
+            AbsolutePath("\(root)/xbin")
         ]
       #else
         let root = ""
@@ -49,7 +49,7 @@ class WalkTests : XCTestCase {
             AbsolutePath("/sbin")
         ]
       #endif
-        for x in try! walk(AbsolutePath.withPOSIX(path: "\(root)/"), recursively: false) {
+        for x in try! walk(AbsolutePath("\(root)/"), recursively: false) {
             if let i = expected.firstIndex(of: x) {
                 expected.remove(at: i)
             }