Skip to content
This repository was archived by the owner on Sep 20, 2019. It is now read-only.

Commit a54d0a2

Browse files
committed
Require Go 1.12
1 parent bb161fe commit a54d0a2

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM golang:1.11.2 as builder
1+
FROM golang:1.12 as builder
22
COPY . /go/src/github.com/swisstxt/cloudstack-cloud-controller-manager
33
WORKDIR /go/src/github.com/swisstxt/cloudstack-cloud-controller-manager
44
RUN make clean && CGO_ENABLED=0 GOOS=linux make

README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -108,11 +108,12 @@ Instead, it first obtains the name of the node from Kubernetes, then fetches inf
108108

109109
### Building
110110

111-
All dependencies are vendored.
112-
You need GNU make, git and Go 1.11 to build cloudstack-ccm.
111+
Go 1.12 is required to build cloudstack-ccm.
113112

114-
It's still possible to build with Go 1.10, but you need to remove the option `-mod vendor` from the
115-
`cloudstack-ccm` compilation target in the `Makefile`.
113+
It is recommended to build with Go module support, but dependencies are also vendored.
114+
115+
To build the controller with correct versioning, some build flags need to be passed.
116+
A Makefile is provided that sets these build flags to values obtained from git.
116117

117118
```bash
118119
go get github.com/swisstxt/cloudstack-cloud-controller-manager

go.mod

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
module github.com/swisstxt/cloudstack-cloud-controller-manager
22

3+
go 1.12
4+
35
require (
46
github.com/spf13/pflag v1.0.3
57
github.com/xanzy/go-cloudstack v2.4.1+incompatible

0 commit comments

Comments
 (0)