fix: interoperability between number, integer, and id (#2883)

sxyazi · web-flow · commit 56a4e87d7e97 · 2025-06-16T13:18:07.000+08:00
diff --git a/yazi-core/src/notify/commands/push.rs b/yazi-core/src/notify/commands/push.rs
@@ -1,7 +1,6 @@
-use std::time::Instant;
+use std::time::{Duration, Instant};
 
-use yazi_macro::emit;
-use yazi_shared::event::Cmd;
+use yazi_proxy::AppProxy;
 
 use crate::notify::{Message, Notify};
 
@@ -14,7 +13,7 @@ impl Notify {
 
 		if self.messages.iter().all(|m| m != &msg) {
 			self.messages.push(msg);
-			emit!(Call(Cmd::args("app:update_notify", [0])));
+			AppProxy::update_notify(Duration::ZERO);
 		}
 	}
 }
diff --git a/yazi-core/src/notify/commands/tick.rs b/yazi-core/src/notify/commands/tick.rs
@@ -1,7 +1,7 @@
 use std::time::Duration;
 
 use ratatui::layout::Rect;
-use yazi_macro::emit;
+use yazi_proxy::AppProxy;
 use yazi_shared::event::{Cmd, CmdCow, Data};
 
 use crate::notify::Notify;
@@ -69,7 +69,7 @@ impl Notify {
 
 		self.tick_handle = Some(tokio::spawn(async move {
 			tokio::time::sleep(interval).await;
-			emit!(Call(Cmd::args("app:update_notify", [interval.as_secs_f64()])));
+			AppProxy::update_notify(interval);
 		}));
 	}
 }
diff --git a/yazi-proxy/src/app.rs b/yazi-proxy/src/app.rs
@@ -9,24 +9,24 @@ use crate::options::{NotifyLevel, NotifyOpt, PluginOpt};
 pub struct AppProxy;
 
 impl AppProxy {
-	#[inline]
 	pub async fn stop() {
 		let (tx, rx) = oneshot::channel::<()>();
 		emit!(Call(Cmd::new("app:stop").with_any("tx", tx)));
 		rx.await.ok();
 	}
 
-	#[inline]
 	pub fn resume() {
 		emit!(Call(Cmd::new("app:resume")));
 	}
 
-	#[inline]
 	pub fn notify(opt: NotifyOpt) {
 		emit!(Call(Cmd::new("app:notify").with_any("option", opt)));
 	}
 
-	#[inline]
+	pub fn update_notify(dur: Duration) {
+		emit!(Call(Cmd::args("app:update_notify", [dur.as_secs_f64()])));
+	}
+
 	pub fn notify_warn(title: &str, content: impl ToString) {
 		Self::notify(NotifyOpt {
 			title:   title.to_owned(),
@@ -36,7 +36,6 @@ impl AppProxy {
 		});
 	}
 
-	#[inline]
 	pub fn notify_error(title: &str, content: impl ToString) {
 		Self::notify(NotifyOpt {
 			title:   title.to_owned(),
@@ -46,12 +45,10 @@ impl AppProxy {
 		});
 	}
 
-	#[inline]
 	pub fn plugin(opt: PluginOpt) {
 		emit!(Call(Cmd::new("app:plugin").with_any("opt", opt)));
 	}
 
-	#[inline]
 	pub fn plugin_do(opt: PluginOpt) {
 		emit!(Call(Cmd::new("app:plugin_do").with_any("opt", opt)));
 	}
diff --git a/yazi-proxy/src/cmp.rs b/yazi-proxy/src/cmp.rs
@@ -4,12 +4,10 @@ use yazi_shared::{Id, event::Cmd};
 pub struct CmpProxy;
 
 impl CmpProxy {
-	#[inline]
 	pub fn close() {
 		emit!(Call(Cmd::new("cmp:close")));
 	}
 
-	#[inline]
 	pub fn trigger(word: &str, ticket: Id) {
 		emit!(Call(Cmd::args("cmp:trigger", [word]).with("ticket", ticket)));
 	}
diff --git a/yazi-proxy/src/confirm.rs b/yazi-proxy/src/confirm.rs
@@ -6,10 +6,8 @@ use yazi_shared::event::Cmd;
 pub struct ConfirmProxy;
 
 impl ConfirmProxy {
-	#[inline]
 	pub async fn show(cfg: ConfirmCfg) -> bool { Self::show_rx(cfg).await.unwrap_or(false) }
 
-	#[inline]
 	pub fn show_rx(cfg: ConfirmCfg) -> oneshot::Receiver<bool> {
 		let (tx, rx) = oneshot::channel();
 		emit!(Call(Cmd::new("confirm:show").with_any("tx", tx).with_any("cfg", cfg)));
diff --git a/yazi-proxy/src/input.rs b/yazi-proxy/src/input.rs
@@ -8,14 +8,12 @@ use crate::options::CmpItem;
 pub struct InputProxy;
 
 impl InputProxy {
-	#[inline]
 	pub fn show(cfg: InputCfg) -> mpsc::UnboundedReceiver<Result<String, InputError>> {
 		let (tx, rx) = mpsc::unbounded_channel();
 		emit!(Call(Cmd::new("input:show").with_any("tx", tx).with_any("cfg", cfg)));
 		rx
 	}
 
-	#[inline]
 	pub fn complete(item: &CmpItem, ticket: Id) {
 		emit!(Call(Cmd::new("input:complete").with_any("item", item.clone()).with("ticket", ticket)));
 	}
diff --git a/yazi-proxy/src/mgr.rs b/yazi-proxy/src/mgr.rs
@@ -6,49 +6,40 @@ use crate::options::OpenDoOpt;
 pub struct MgrProxy;
 
 impl MgrProxy {
-	#[inline]
 	pub fn spot(skip: Option<usize>) {
 		emit!(Call(Cmd::new("mgr:spot").with_opt("skip", skip)));
 	}
 
-	#[inline]
 	pub fn peek(force: bool) {
 		emit!(Call(Cmd::new("mgr:peek").with("force", force)));
 	}
 
-	#[inline]
 	pub fn watch() {
 		emit!(Call(Cmd::new("mgr:watch")));
 	}
 
-	#[inline]
 	pub fn refresh() {
 		emit!(Call(Cmd::new("mgr:refresh")));
 	}
 
-	#[inline]
 	pub fn open_do(opt: OpenDoOpt) {
 		emit!(Call(Cmd::new("mgr:open_do").with_any("option", opt)));
 	}
 
-	#[inline]
 	pub fn remove_do(targets: Vec<Url>, permanently: bool) {
 		emit!(Call(
 			Cmd::new("mgr:remove_do").with("permanently", permanently).with_any("targets", targets)
 		));
 	}
 
-	#[inline]
 	pub fn update_tasks(url: &Url) {
 		emit!(Call(Cmd::new("mgr:update_tasks").with_any("urls", vec![url.clone()])));
 	}
 
-	#[inline]
 	pub fn update_paged() {
 		emit!(Call(Cmd::new("mgr:update_paged")));
 	}
 
-	#[inline]
 	pub fn update_paged_by(page: usize, only_if: &Url) {
 		emit!(Call(Cmd::args("mgr:update_paged", [page]).with_any("only-if", only_if.clone())));
 	}
diff --git a/yazi-proxy/src/options/notify.rs b/yazi-proxy/src/options/notify.rs
@@ -52,7 +52,6 @@ pub enum NotifyLevel {
 }
 
 impl NotifyLevel {
-	#[inline]
 	pub fn icon(self) -> &'static str {
 		match self {
 			Self::Info => &THEME.notify.icon_info,
@@ -61,7 +60,6 @@ impl NotifyLevel {
 		}
 	}
 
-	#[inline]
 	pub fn style(self) -> &'static Style {
 		match self {
 			Self::Info => &THEME.notify.title_info,
diff --git a/yazi-proxy/src/pick.rs b/yazi-proxy/src/pick.rs
@@ -6,7 +6,6 @@ use yazi_shared::event::Cmd;
 pub struct PickProxy;
 
 impl PickProxy {
-	#[inline]
 	pub async fn show(cfg: PickCfg) -> anyhow::Result<usize> {
 		let (tx, rx) = oneshot::channel();
 		emit!(Call(Cmd::new("pick:show").with_any("tx", tx).with_any("cfg", cfg)));
diff --git a/yazi-proxy/src/tab.rs b/yazi-proxy/src/tab.rs
@@ -8,22 +8,18 @@ use crate::options::SearchOpt;
 pub struct TabProxy;
 
 impl TabProxy {
-	#[inline]
 	pub fn cd(target: &Url) {
 		emit!(Call(Cmd::args("mgr:cd", [target])));
 	}
 
-	#[inline]
 	pub fn reveal(target: &Url) {
 		emit!(Call(Cmd::args("mgr:reveal", [target]).with("no-dummy", true)));
 	}
 
-	#[inline]
 	pub fn arrow(step: impl Into<Cow<'static, str>>) {
 		emit!(Call(Cmd::args("mgr:arrow", [step.into()])));
 	}
 
-	#[inline]
 	pub fn search_do(opt: SearchOpt) {
 		emit!(Call(
 			// TODO: use second positional argument instead of `args` parameter
diff --git a/yazi-proxy/src/tasks.rs b/yazi-proxy/src/tasks.rs
@@ -10,7 +10,6 @@ use crate::options::{OpenWithOpt, ProcessExecOpt};
 pub struct TasksProxy;
 
 impl TasksProxy {
-	#[inline]
 	pub fn open_with(opener: Cow<'static, OpenerRule>, cwd: Url, targets: Vec<Url>) {
 		emit!(Call(Cmd::new("tasks:open_with").with_any("option", OpenWithOpt {
 			opener,
@@ -19,7 +18,6 @@ impl TasksProxy {
 		})));
 	}
 
-	#[inline]
 	pub async fn process_exec(opener: Cow<'static, OpenerRule>, cwd: Url, args: Vec<OsString>) {
 		let (tx, rx) = oneshot::channel();
 		emit!(Call(Cmd::new("tasks:process_exec").with_any("option", ProcessExecOpt {
diff --git a/yazi-shared/src/event/data.rs b/yazi-shared/src/event/data.rs
@@ -90,6 +90,14 @@ impl From<bool> for Data {
 	fn from(value: bool) -> Self { Self::Boolean(value) }
 }
 
+impl From<i32> for Data {
+	fn from(value: i32) -> Self { Self::Integer(value as i64) }
+}
+
+impl From<i64> for Data {
+	fn from(value: i64) -> Self { Self::Integer(value) }
+}
+
 impl From<f64> for Data {
 	fn from(value: f64) -> Self { Self::Number(value) }
 }
@@ -187,7 +195,7 @@ impl From<String> for DataKey {
 }
 
 // --- Macros
-macro_rules! impl_integer_as {
+macro_rules! impl_as_integer {
 	($t:ty, $name:ident) => {
 		impl Data {
 			#[inline]
@@ -203,26 +211,27 @@ macro_rules! impl_integer_as {
 	};
 }
 
-macro_rules! impl_number_as {
+macro_rules! impl_as_number {
 	($t:ty, $name:ident) => {
 		impl Data {
 			#[inline]
 			pub fn $name(&self) -> Option<$t> {
 				match self {
+					Data::Integer(i) if *i == (*i as $t as _) => Some(*i as $t),
 					Data::Number(n) => <$t>::try_from(*n).ok(),
 					Data::String(s) => s.parse().ok(),
+					Data::Id(i) if i.0 == (i.0 as $t as _) => Some(i.0 as $t),
 					_ => None,
 				}
 			}
 		}
 	};
 }
 
-impl_integer_as!(usize, as_usize);
-impl_integer_as!(isize, as_isize);
-impl_integer_as!(i16, as_i16);
-impl_integer_as!(i32, as_i32);
-
-impl_number_as!(f64, as_f64);
+impl_as_integer!(usize, as_usize);
+impl_as_integer!(isize, as_isize);
+impl_as_integer!(i16, as_i16);
+impl_as_integer!(i32, as_i32);
+impl_as_integer!(crate::Id, as_id);
 
-impl_integer_as!(crate::Id, as_id);
+impl_as_number!(f64, as_f64);

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,6 @@`
`1`		`-use std::time::Instant;`
	`1`	`+use std::time::{Duration, Instant};`
`2`	`2`
`3`		`-use yazi_macro::emit;`
`4`		`-use yazi_shared::event::Cmd;`
	`3`	`+use yazi_proxy::AppProxy;`
`5`	`4`
`6`	`5`	`use crate::notify::{Message, Notify};`
`7`	`6`
`@@ -14,7 +13,7 @@ impl Notify {`
`14`	`13`
`15`	`14`	`if self.messages.iter().all(\|m\| m != &msg) {`
`16`	`15`	`self.messages.push(msg);`
`17`		`- emit!(Call(Cmd::args("app:update_notify", [0])));`
	`16`	`+ AppProxy::update_notify(Duration::ZERO);`
`18`	`17`	`}`
`19`	`18`	`}`
`20`	`19`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`use std::time::Duration;`
`2`	`2`
`3`	`3`	`use ratatui::layout::Rect;`
`4`		`-use yazi_macro::emit;`
	`4`	`+use yazi_proxy::AppProxy;`
`5`	`5`	`use yazi_shared::event::{Cmd, CmdCow, Data};`
`6`	`6`
`7`	`7`	`use crate::notify::Notify;`
`@@ -69,7 +69,7 @@ impl Notify {`
`69`	`69`
`70`	`70`	`self.tick_handle = Some(tokio::spawn(async move {`
`71`	`71`	`tokio::time::sleep(interval).await;`
`72`		`- emit!(Call(Cmd::args("app:update_notify", [interval.as_secs_f64()])));`
	`72`	`+ AppProxy::update_notify(interval);`
`73`	`73`	`}));`
`74`	`74`	`}`
`75`	`75`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,12 +4,10 @@ use yazi_shared::{Id, event::Cmd};`
`4`	`4`	`pub struct CmpProxy;`
`5`	`5`
`6`	`6`	`impl CmpProxy {`
`7`		`- #[inline]`
`8`	`7`	`pub fn close() {`
`9`	`8`	`emit!(Call(Cmd::new("cmp:close")));`
`10`	`9`	`}`
`11`	`10`
`12`		`- #[inline]`
`13`	`11`	`pub fn trigger(word: &str, ticket: Id) {`
`14`	`12`	`emit!(Call(Cmd::args("cmp:trigger", [word]).with("ticket", ticket)));`
`15`	`13`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,14 +8,12 @@ use crate::options::CmpItem;`
`8`	`8`	`pub struct InputProxy;`
`9`	`9`
`10`	`10`	`impl InputProxy {`
`11`		`- #[inline]`
`12`	`11`	`pub fn show(cfg: InputCfg) -> mpsc::UnboundedReceiver<Result<String, InputError>> {`
`13`	`12`	`let (tx, rx) = mpsc::unbounded_channel();`
`14`	`13`	`emit!(Call(Cmd::new("input:show").with_any("tx", tx).with_any("cfg", cfg)));`
`15`	`14`	`rx`
`16`	`15`	`}`
`17`	`16`
`18`		`- #[inline]`
`19`	`17`	`pub fn complete(item: &CmpItem, ticket: Id) {`
`20`	`18`	`emit!(Call(Cmd::new("input:complete").with_any("item", item.clone()).with("ticket", ticket)));`
`21`	`19`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,49 +6,40 @@ use crate::options::OpenDoOpt;`
`6`	`6`	`pub struct MgrProxy;`
`7`	`7`
`8`	`8`	`impl MgrProxy {`
`9`		`- #[inline]`
`10`	`9`	`pub fn spot(skip: Option<usize>) {`
`11`	`10`	`emit!(Call(Cmd::new("mgr:spot").with_opt("skip", skip)));`
`12`	`11`	`}`
`13`	`12`
`14`		`- #[inline]`
`15`	`13`	`pub fn peek(force: bool) {`
`16`	`14`	`emit!(Call(Cmd::new("mgr:peek").with("force", force)));`
`17`	`15`	`}`
`18`	`16`
`19`		`- #[inline]`
`20`	`17`	`pub fn watch() {`
`21`	`18`	`emit!(Call(Cmd::new("mgr:watch")));`
`22`	`19`	`}`
`23`	`20`
`24`		`- #[inline]`
`25`	`21`	`pub fn refresh() {`
`26`	`22`	`emit!(Call(Cmd::new("mgr:refresh")));`
`27`	`23`	`}`
`28`	`24`
`29`		`- #[inline]`
`30`	`25`	`pub fn open_do(opt: OpenDoOpt) {`
`31`	`26`	`emit!(Call(Cmd::new("mgr:open_do").with_any("option", opt)));`
`32`	`27`	`}`
`33`	`28`
`34`		`- #[inline]`
`35`	`29`	`pub fn remove_do(targets: Vec<Url>, permanently: bool) {`
`36`	`30`	`emit!(Call(`
`37`	`31`	`Cmd::new("mgr:remove_do").with("permanently", permanently).with_any("targets", targets)`
`38`	`32`	`));`
`39`	`33`	`}`
`40`	`34`
`41`		`- #[inline]`
`42`	`35`	`pub fn update_tasks(url: &Url) {`
`43`	`36`	`emit!(Call(Cmd::new("mgr:update_tasks").with_any("urls", vec![url.clone()])));`
`44`	`37`	`}`
`45`	`38`
`46`		`- #[inline]`
`47`	`39`	`pub fn update_paged() {`
`48`	`40`	`emit!(Call(Cmd::new("mgr:update_paged")));`
`49`	`41`	`}`
`50`	`42`
`51`		`- #[inline]`
`52`	`43`	`pub fn update_paged_by(page: usize, only_if: &Url) {`
`53`	`44`	`emit!(Call(Cmd::args("mgr:update_paged", [page]).with_any("only-if", only_if.clone())));`
`54`	`45`	`}`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,6 @@ pub enum NotifyLevel {`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`impl NotifyLevel {`
`55`		`- #[inline]`
`56`	`55`	`pub fn icon(self) -> &'static str {`
`57`	`56`	`match self {`
`58`	`57`	`Self::Info => &THEME.notify.icon_info,`
`@@ -61,7 +60,6 @@ impl NotifyLevel {`
`61`	`60`	`}`
`62`	`61`	`}`
`63`	`62`
`64`		`- #[inline]`
`65`	`63`	`pub fn style(self) -> &'static Style {`
`66`	`64`	`match self {`
`67`	`65`	`Self::Info => &THEME.notify.title_info,`
Original file line number	Diff line number	Diff line change
`@@ -8,22 +8,18 @@ use crate::options::SearchOpt;`
`8`	`8`	`pub struct TabProxy;`
`9`	`9`
`10`	`10`	`impl TabProxy {`
`11`		`- #[inline]`
`12`	`11`	`pub fn cd(target: &Url) {`
`13`	`12`	`emit!(Call(Cmd::args("mgr:cd", [target])));`
`14`	`13`	`}`
`15`	`14`
`16`		`- #[inline]`
`17`	`15`	`pub fn reveal(target: &Url) {`
`18`	`16`	`emit!(Call(Cmd::args("mgr:reveal", [target]).with("no-dummy", true)));`
`19`	`17`	`}`
`20`	`18`
`21`		`- #[inline]`
`22`	`19`	`pub fn arrow(step: impl Into<Cow<'static, str>>) {`
`23`	`20`	`emit!(Call(Cmd::args("mgr:arrow", [step.into()])));`
`24`	`21`	`}`
`25`	`22`
`26`		`- #[inline]`
`27`	`23`	`pub fn search_do(opt: SearchOpt) {`
`28`	`24`	`emit!(Call(`
`29`	`25`	// TODO: use second positional argument instead of `args` parameter