feat!: live editing of remote files (#3264)

Author: sxyazi

Cargo.lock

@@ -24,31 +24,31 @@ ansi-to-tui         = "7.0.0"
 anyhow              = "1.0.100"
 base64              = "0.22.1"
 bitflags            = { version = "2.9.4", features = [ "serde" ] }
-clap                = { version = "4.5.48", features = [ "derive" ] }
+clap                = { version = "4.5.49", features = [ "derive" ] }
 core-foundation-sys = "0.8.7"
 crossterm           = { version = "0.29.0", features = [ "event-stream" ] }
 dirs                = "6.0.0"
 foldhash            = "0.2.0"
 futures             = "0.3.31"
-globset             = "0.4.16"
+globset             = "0.4.17"
 hashbrown           = { version = "0.16.0", features = [ "serde" ] }
-indexmap            = { version = "2.11.4", features = [ "serde" ] }
+indexmap            = { version = "2.12.0", features = [ "serde" ] }
 libc                = "0.2.177"
-lru                 = "0.16.1"
+lru                 = "0.16.2"
 mlua                = { version = "0.11.4", features = [ "anyhow", "async", "error-send", "lua54", "macros", "serde" ] }
 objc                = "0.2.7"
 ordered-float       = { version = "5.1.0", features = [ "serde" ] }
 parking_lot         = "0.12.5"
 paste               = "1.0.15"
 percent-encoding    = "2.3.2"
 ratatui             = { version = "0.29.0", features = [ "unstable-rendered-line-info", "unstable-widget-ref" ] }
-regex               = "1.12.1"
-russh               = { version = "0.54.5", default-features = false, features = [ "ring", "rsa" ] }
+regex               = "1.12.2"
+russh               = { version = "0.54.6", default-features = false, features = [ "ring", "rsa" ] }
 scopeguard          = "1.2.0"
 serde               = { version = "1.0.228", features = [ "derive" ] }
 serde_json          = "1.0.145"
 syntect             = { version = "5.3.0", default-features = false, features = [ "parsing", "plist-load", "regex-onig" ] }
-tokio               = { version = "1.47.1", features = [ "full" ] }
+tokio               = { version = "1.48.0", features = [ "full" ] }
 tokio-stream        = "0.1.17"
 tokio-util          = "0.7.16"
 toml                = { version = "0.9.8" }

Cargo.toml

@@ -52,7 +52,7 @@ impl Actor for BulkRename {
 
 			defer! { tokio::spawn(Local.remove_file(tmp.clone())); }
 			TasksProxy::process_exec(
-				cwd,
+				cwd.into(),
 				Splatter::new(&[UrlCow::default(), tmp.as_url().into()]).splat(&opener.run),
 				vec![UrlCow::default(), UrlBuf::from(&tmp).into()],
 				opener.block,

yazi-actor/src/mgr/bulk_rename.rs

@@ -2,11 +2,13 @@ use std::{mem, time::{Duration, Instant}};
 
 use anyhow::Result;
 use futures::{StreamExt, stream::FuturesUnordered};
+use hashbrown::HashSet;
 use tokio::sync::oneshot;
-use yazi_fs::File;
-use yazi_macro::{act, succ};
-use yazi_parser::mgr::DownloadOpt;
-use yazi_shared::data::Data;
+use yazi_fs::{File, FsUrl, provider::{Provider, local::Local}};
+use yazi_macro::succ;
+use yazi_parser::mgr::{DownloadOpt, OpenOpt};
+use yazi_proxy::MgrProxy;
+use yazi_shared::{data::Data, url::UrlCow};
 use yazi_vfs::VfsFile;
 
 use crate::{Actor, Ctx};
@@ -19,26 +21,30 @@ impl Actor for Download {
 	const NAME: &str = "download";
 
 	fn act(cx: &mut Ctx, opt: Self::Options) -> Result<Data> {
-		act!(mgr:escape_visual, cx)?;
-
-		let mut wg1 = FuturesUnordered::new();
-		for url in opt.urls {
-			let (tx, rx) = oneshot::channel();
-			cx.tasks.scheduler.file_download(url.to_owned(), Some(tx));
-			wg1.push(async move { (rx.await == Ok(true), url) });
-		}
-
+		let cwd = cx.cwd().clone();
 		let scheduler = cx.tasks.scheduler.clone();
+
 		tokio::spawn(async move {
+			Self::prepare(&opt.urls).await;
+
+			let mut wg1 = FuturesUnordered::new();
+			for url in opt.urls {
+				let (tx, rx) = oneshot::channel();
+				scheduler.file_download(url.to_owned(), Some(tx));
+				wg1.push(async move { (rx.await == Ok(false), url) });
+			}
+
 			let mut wg2 = vec![];
+			let mut urls = Vec::with_capacity(wg1.len());
 			let mut files = Vec::with_capacity(wg1.len());
 			let mut instant = Instant::now();
 			while let Some((success, url)) = wg1.next().await {
 				if !success {
 					continue;
 				}
 
-				let Ok(f) = File::new(url).await else { continue };
+				let Ok(f) = File::new(&url).await else { continue };
+				urls.push(url);
 				files.push(f);
 
 				if instant.elapsed() >= Duration::from_secs(1) {
@@ -50,9 +56,29 @@ impl Actor for Download {
 			if !files.is_empty() {
 				wg2.push(scheduler.fetch_mimetype(files));
 			}
-			futures::future::join_all(wg2).await;
+			if futures::future::join_all(wg2).await.into_iter().any(|b| !b) {
+				return;
+			}
+			if opt.open && !urls.is_empty() {
+				MgrProxy::open(OpenOpt {
+					cwd:         Some(cwd.into()),
+					targets:     urls,
+					interactive: false,
+					hovered:     false,
+				});
+			}
 		});
 
 		succ!();
 	}
 }
+
+impl Download {
+	async fn prepare(urls: &[UrlCow<'_>]) {
+		let roots: HashSet<_> = urls.iter().filter_map(|u| u.cache_root()).collect();
+		for mut root in roots {
+			root.push("%lock");
+			Local.create_dir_all(root).await.ok();
+		}
+	}
+}

yazi-actor/src/mgr/download.rs

@@ -48,7 +48,7 @@ impl Actor for Open {
 			.map(|(i, _)| i)
 			.collect();
 
-		let cwd = cx.cwd().clone();
+		let cwd = opt.cwd.unwrap_or_else(|| cx.cwd().clone().into());
 		if todo.is_empty() {
 			return act!(mgr:open_do, cx, OpenDoOpt { cwd, targets: opt.targets, interactive: opt.interactive });
 		}

yazi-actor/src/mgr/open.rs

@@ -5,7 +5,7 @@ use yazi_fs::Splatter;
 use yazi_macro::succ;
 use yazi_parser::{mgr::OpenDoOpt, tasks::ProcessOpenOpt};
 use yazi_proxy::{PickProxy, TasksProxy};
-use yazi_shared::{data::Data, url::{UrlBuf, UrlCow}};
+use yazi_shared::{data::Data, url::UrlCow};
 
 use crate::{Actor, Ctx};
 
@@ -60,7 +60,7 @@ impl Actor for OpenDo {
 
 impl OpenDo {
 	// TODO: remove
-	fn match_and_open(cx: &Ctx, cwd: UrlBuf, targets: Vec<(UrlCow<'static>, &str)>) {
+	fn match_and_open(cx: &Ctx, cwd: UrlCow<'static>, targets: Vec<(UrlCow<'static>, &str)>) {
 		let mut openers = HashMap::new();
 		for (url, mime) in targets {
 			if let Some(opener) = YAZI.opener.first(YAZI.open.all(&url, mime)) {

yazi-actor/src/mgr/open_do.rs

@@ -39,12 +39,12 @@ impl Actor for Shell {
 			}
 
 			TasksProxy::open_shell_compat(ProcessOpenOpt {
-				cwd,
-				cmd: Splatter::new(&selected).splat(opt.run.as_ref()),
-				args: selected,
-				block: opt.block,
+				cwd:    cwd.into(),
+				cmd:    Splatter::new(&selected).splat(opt.run.as_ref()),
+				args:   selected,
+				block:  opt.block,
 				orphan: opt.orphan,
-				done: None,
+				done:   None,
 				spread: true,
 			});
 		});

yazi-actor/src/mgr/shell.rs

@@ -1,4 +1,4 @@
-use std::{env, fmt::Display, path::Path};
+use std::{env, fmt::Display, path::PathBuf};
 
 use anyhow::Result;
 use ratatui::layout::Rect;
@@ -35,11 +35,15 @@ impl Display for Adapter {
 }
 
 impl Adapter {
-	pub async fn image_show(self, path: &Path, max: Rect) -> Result<Rect> {
+	pub async fn image_show<P>(self, path: P, max: Rect) -> Result<Rect>
+	where
+		P: Into<PathBuf>,
+	{
 		if max.is_empty() {
 			return Ok(Rect::default());
 		}
 
+		let path = path.into();
 		match self {
 			Self::Kgp => drivers::Kgp::image_show(path, max).await,
 			Self::KgpOld => drivers::KgpOld::image_show(path, max).await,

yazi-adapter/src/adapter.rs

@@ -1,4 +1,4 @@
-use std::{io::Write, path::Path, process::Stdio};
+use std::{io::Write, path::PathBuf, process::Stdio};
 
 use ansi_to_tui::IntoText;
 use anyhow::{Result, bail};
@@ -11,7 +11,7 @@ use crate::{Adapter, Emulator};
 pub(crate) struct Chafa;
 
 impl Chafa {
-	pub(crate) async fn image_show(path: &Path, max: Rect) -> Result<Rect> {
+	pub(crate) async fn image_show(path: PathBuf, max: Rect) -> Result<Rect> {
 		let child = Command::new("chafa")
 			.args([
 				"-f",

yazi-adapter/src/drivers/chafa.rs

@@ -1,4 +1,4 @@
-use std::{fmt::Write, io::Write as ioWrite, path::Path};
+use std::{fmt::Write, io::Write as ioWrite, path::PathBuf};
 
 use anyhow::Result;
 use base64::{Engine, engine::{Config, general_purpose::STANDARD}};
@@ -12,7 +12,7 @@ use crate::{CLOSE, Emulator, Image, START, adapter::Adapter};
 pub(crate) struct Iip;
 
 impl Iip {
-	pub(crate) async fn image_show(path: &Path, max: Rect) -> Result<Rect> {
+	pub(crate) async fn image_show(path: PathBuf, max: Rect) -> Result<Rect> {
 		let img = Image::downscale(path, max).await?;
 		let area = Image::pixel_area((img.width(), img.height()), max);
 		let b = Self::encode(img).await?;