Skip to content

Commit 6901b60

Browse files
authored
Apply suggestions from code review
1 parent 94d52f1 commit 6901b60

File tree

5 files changed

+24
-1
lines changed

5 files changed

+24
-1
lines changed

src/platform/src/Bridge/Anthropic/Tests/Contract/AssistantMessageNormalizerTest.php

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,18 @@ public function testNormalize(AssistantMessage $message, array $expectedOutput)
4949
}
5050

5151
/**
52-
* @return iterable<string, array{0: AssistantMessage, 1: array}>
52+
* @return iterable<string, array{
53+
* 0: AssistantMessage,
54+
* 1: array{
55+
* role: 'assistant',
56+
* content: string|list<array{
57+
* type: 'tool_use',
58+
* id: string,
59+
* name: string,
60+
* input: array<string, mixed>|\stdClass
61+
* }>
62+
* }
63+
* }>
5364
*/
5465
public static function normalizeDataProvider(): iterable
5566
{

src/platform/src/Bridge/Bedrock/Tests/Nova/ContractTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,9 @@ public function testConvert(MessageBag $bag, array $expected)
4040
$this->assertEquals($expected, $contract->createRequestPayload(new Nova('nova-pro'), $bag));
4141
}
4242

43+
/**
44+
* @return iterable<array{0: MessageBag, 1: array}>
45+
*/
4346
public static function provideMessageBag(): iterable
4447
{
4548
yield 'simple text' => [

src/platform/src/Bridge/Gemini/Tests/Contract/AssistantMessageNormalizerTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,9 @@ public function testNormalize(AssistantMessage $message, array $expectedOutput)
4848
$this->assertSame($expectedOutput, $normalized);
4949
}
5050

51+
/**
52+
* @return iterable<string, array{AssistantMessage, array{text?: string, functionCall?: array{id: string, name: string, args?: mixed}}[]}>
53+
*/
5154
public static function normalizeDataProvider(): iterable
5255
{
5356
yield 'assistant message' => [

src/platform/src/Bridge/Gemini/Tests/Contract/MessageBagNormalizerTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,9 @@ public function testNormalize(MessageBag $bag, array $expected)
7676
$this->assertEquals($expected, $normalized);
7777
}
7878

79+
/**
80+
* @return iterable<array{0: MessageBag, 1: array}>
81+
*/
7982
public static function provideMessageBagData(): iterable
8083
{
8184
yield 'simple text' => [

src/platform/src/Bridge/HuggingFace/Tests/Contract/MessageBagNormalizerTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,9 @@ public function testNormalize(MessageBag $bag, array $expected)
7373
$this->assertEquals($expected, $normalized);
7474
}
7575

76+
/**
77+
* @return iterable<array{0: MessageBag, 1: array}>
78+
*/
7679
public static function provideMessageBagData(): iterable
7780
{
7881
yield 'simple text message' => [

0 commit comments

Comments
 (0)