minor #1112 Add validation job to verify bridges are in splitsh.json (OskarStark)

This PR was merged into the main branch.

Discussion
----------

 Add validation job to verify bridges are in `splitsh.json`

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| Docs?         | no
| Issues        | --
| License       | MIT

Commits
-------

dbf9cdc Add validation job to verify bridges are in splitsh.json

Author: OskarStark

.github/scripts/validate-bridge-splitsh.sh

@@ -0,0 +1,56 @@
+#!/bin/bash
+#
+# Validates that all bridge directories are configured in splitsh.json.
+#
+# Usage: validate-bridge-splitsh.sh <bridge_type> <bridge_path>
+#
+# Arguments:
+#   bridge_type     Type of bridge (e.g., "store", "tool") - used in output messages
+#   bridge_path     Path pattern to bridge directories (e.g., "src/store/src/Bridge/*")
+#
+# Example:
+#   validate-bridge-splitsh.sh store "src/store/src/Bridge/*"
+#   validate-bridge-splitsh.sh tool "src/agent/src/Bridge/*"
+
+set -e
+
+BRIDGE_TYPE="${1:?Bridge type is required (e.g., store, tool)}"
+BRIDGE_PATH="${2:?Bridge path pattern is required (e.g., src/store/src/Bridge/*)}"
+
+SPLITSH_FILE="splitsh.json"
+
+if [[ ! -f "$SPLITSH_FILE" ]]; then
+    echo "::error::splitsh.json not found"
+    exit 1
+fi
+
+ERRORS=0
+
+echo "Validating ${BRIDGE_TYPE} bridges (${BRIDGE_PATH})..."
+for bridge_dir in ${BRIDGE_PATH}/; do
+    if [[ ! -d "$bridge_dir" ]]; then
+        continue
+    fi
+
+    bridge_name=$(basename "$bridge_dir")
+    # Remove trailing /* from bridge_path and append bridge_name
+    base_path="${BRIDGE_PATH%/*}"
+    expected_path="${base_path}/${bridge_name}"
+
+    # Check if the path exists in splitsh.json
+    if ! jq -e --arg path "$expected_path" 'any(.subtrees[]; . == $path or (type == "object" and .prefixes[0].from == $path))' "$SPLITSH_FILE" > /dev/null 2>&1; then
+        echo "::error file=$SPLITSH_FILE::${BRIDGE_TYPE} bridge '$bridge_name' at '$expected_path' is not configured in splitsh.json"
+        ERRORS=$((ERRORS + 1))
+    else
+        echo "✓ $bridge_name: configured in splitsh.json"
+    fi
+done
+
+if [[ $ERRORS -gt 0 ]]; then
+    echo ""
+    echo "::error::Found $ERRORS ${BRIDGE_TYPE} bridge(s) missing from splitsh.json"
+    exit 1
+fi
+
+echo ""
+echo "All ${BRIDGE_TYPE} bridges are correctly configured in splitsh.json!"

.github/workflows/validation.yaml

@@ -5,22 +5,26 @@ on:
         paths:
             - 'src/*/src/Bridge/**/composer.json'
             - 'src/ai-bundle/config/options.php'
+            - 'splitsh.json'
             - '.github/workflows/validation.yaml'
             - '.github/scripts/validate-bridge-naming.sh'
+            - '.github/scripts/validate-bridge-splitsh.sh'
     pull_request:
         paths:
             - 'src/*/src/Bridge/**/composer.json'
             - 'src/ai-bundle/config/options.php'
+            - 'splitsh.json'
             - '.github/workflows/validation.yaml'
             - '.github/scripts/validate-bridge-naming.sh'
+            - '.github/scripts/validate-bridge-splitsh.sh'
 
 concurrency:
     group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
     cancel-in-progress: true
 
 jobs:
     validate_stores:
-        name: Store Bridge Naming
+        name: Store Bridges
         runs-on: ubuntu-latest
         steps:
             - name: Checkout
@@ -29,12 +33,18 @@ jobs:
             - name: Validate store bridge naming conventions
               run: .github/scripts/validate-bridge-naming.sh store "src/store/src/Bridge/*" src/ai-bundle/config/options.php
 
+            - name: Validate store bridges are in splitsh.json
+              run: .github/scripts/validate-bridge-splitsh.sh store "src/store/src/Bridge/*"
+
     validate_tools:
-        name: Tool Bridge Naming
+        name: Tool Bridges
         runs-on: ubuntu-latest
         steps:
             - name: Checkout
               uses: actions/checkout@v6
 
             - name: Validate tool bridge naming conventions
               run: .github/scripts/validate-bridge-naming.sh tool "src/agent/src/Bridge/*"
+
+            - name: Validate tool bridges are in splitsh.json
+              run: .github/scripts/validate-bridge-splitsh.sh tool "src/agent/src/Bridge/*"