Remove always true/false occurrences

Author: alexandre-daubois

DependencyInjection/Compiler/ReplaceDecoratedRememberMeHandlerPass.php

@@ -37,9 +37,6 @@ public function process(ContainerBuilder $container): void
 
             // get the actual custom remember me handler definition (passed to the decorator)
             $realRememberMeHandler = $container->findDefinition((string) $definition->getArgument(0));
-            if (null === $realRememberMeHandler) {
-                throw new \LogicException(\sprintf('Invalid service definition for custom remember me handler; no service found with ID "%s".', (string) $definition->getArgument(0)));
-            }
 
             foreach ($rememberMeHandlerTags as $rememberMeHandlerTag) {
                 // some custom handlers may be used on multiple firewalls in the same application

Tests/Functional/Bundle/SecuredPageBundle/Security/Core/User/ArrayUserProvider.php

@@ -12,7 +12,6 @@
 namespace Symfony\Bundle\SecurityBundle\Tests\Functional\Bundle\SecuredPageBundle\Security\Core\User;
 
 use Symfony\Bundle\SecurityBundle\Tests\Functional\UserWithoutEquatable;
-use Symfony\Component\Security\Core\Exception\UnsupportedUserException;
 use Symfony\Component\Security\Core\Exception\UserNotFoundException;
 use Symfony\Component\Security\Core\User\InMemoryUser;
 use Symfony\Component\Security\Core\User\UserInterface;
@@ -59,10 +58,6 @@ public function loadUserByIdentifier(string $identifier): UserInterface
 
     public function refreshUser(UserInterface $user): UserInterface
     {
-        if (!$user instanceof UserInterface) {
-            throw new UnsupportedUserException(\sprintf('Instances of "%s" are not supported.', get_debug_type($user)));
-        }
-
         $storedUser = $this->getUser($user->getUserIdentifier());
         $class = $storedUser::class;