Remove tests that is already tested in serde-de, struct_::non_closed

Author: Mingun

tests/serde-de.rs

@@ -742,6 +742,65 @@ macro_rules! maplike_errors {
                 }
             }
         }
+
+        mod incomplete_tag {
+            use super::*;
+            use quick_xml::errors::{Error, SyntaxError};
+
+            #[test]
+            fn attributes() {
+                let err = from_str::<$attributes>(
+                    // Comment for prevent unnecessary formatting - we use the same style in all tests
+                    r#"<root float="42" string="answer""#,
+                )
+                .unwrap_err();
+                match err {
+                    // TODO: add error position to errors and check it here
+                    // Related: https://github.com/tafia/quick-xml/issues/625
+                    DeError::InvalidXml(Error::Syntax(SyntaxError::UnclosedTag)) => (),
+                    _ => panic!(
+                        "Expected `Err(InvalidXml(Syntax(UnclosedTag)))`, but got `{:?}`",
+                        err
+                    ),
+                }
+            }
+
+            #[test]
+            fn elements_root() {
+                let err = from_str::<$mixed>(
+                    // Comment for prevent unnecessary formatting - we use the same style in all tests
+                    r#"<root float="42"><string>answer</string><root"#,
+                )
+                .unwrap_err();
+                match err {
+                    // TODO: add error position to errors and check it here
+                    // Related: https://github.com/tafia/quick-xml/issues/625
+                    DeError::InvalidXml(Error::Syntax(SyntaxError::UnclosedTag)) => (),
+                    _ => panic!(
+                        "Expected `Err(InvalidXml(Syntax(UnclosedTag)))`, but got `{:?}`",
+                        err
+                    ),
+                }
+            }
+
+            #[test]
+            fn elements_child() {
+                let err = from_str::<$mixed>(
+                    // Comment for prevent unnecessary formatting - we use the same style in all tests
+                    r#"<root float="42"><string>answer</string"#,
+                )
+                .unwrap_err();
+                match err {
+                    // TODO: add error position to errors and check it here
+                    // Related: https://github.com/tafia/quick-xml/issues/625
+                    DeError::InvalidXml(Error::Syntax(SyntaxError::UnclosedTag)) => (),
+                    _ => panic!(
+                        "Expected `Err(InvalidXml(Syntax(UnclosedTag)))`, but got `{:?}`",
+                        err
+                    ),
+                }
+            }
+        }
     };
 }
 

tests/serde-migrated.rs

@@ -6,14 +6,6 @@ use serde::{Deserialize, Serialize};
 
 use pretty_assertions::assert_eq;
 
-#[derive(PartialEq, Debug, Serialize, Deserialize)]
-struct Simple {
-    a: (),
-    b: usize,
-    c: String,
-    d: Option<String>,
-}
-
 #[track_caller]
 fn test_parse_ok<'a, T: std::fmt::Debug>(errors: &[(&'a str, T)])
 where
@@ -38,16 +30,6 @@ where
     }
 }
 
-#[track_caller]
-fn test_parse_err<'a, T>(errors: &[&'a str])
-where
-    T: PartialEq + Debug + ser::Serialize + for<'de> de::Deserialize<'de>,
-{
-    for &s in errors {
-        assert!(from_str::<T>(s).is_err());
-    }
-}
-
 #[test]
 fn test_namespaces() {
     #[derive(PartialEq, Serialize, Deserialize, Debug)]
@@ -91,17 +73,3 @@ fn test_forwarded_namespace() {
         },
     )]);
 }
-
-#[test]
-fn test_parse_unfinished() {
-    test_parse_err::<Simple>(&["<Simple>
-            <c>abc</c>
-            <a/>
-            <b>2</b>
-            <d/>"]);
-}
-
-#[test]
-fn test_things_qc_found() {
-    test_parse_err::<u32>(&["<\u{0}:/"]);
-}