Add support for -XepAllSuggestionsAsWarnings

That flag was added in Error Prone 2.20.0 but somehow flew
under my radar.
There's also an -XepCompilingPubliclyVisibleCode that was
added in the version, but nobody seems to be using it; it
might be specific to Google's own internal checks about
what's private code and what's public in their monorepo.

Author: tbroyer

README.md

@@ -270,6 +270,7 @@ _Please note that all properties are [lazy](https://docs.gradle.org/current/user
 | `disableAllChecks`               | Disable all Error Prone checks; maps to `-XepDisableAllChecks`. This will be the first argument, so checks can then be re-enabled on a case-by-case basis. Defaults to `false`.
 | `disableAllWarnings`             | Maps to `-XepDisableAllWarnings` (since ErrorProne 2.4.0). Defaults to `false`.
 | `allErrorsAsWarnings`            | Maps to `-XepAllErrorsAsWarnings`. Defaults to `false`.
+| `allSuggestionsAsWarnings`       | (since ErrorProne 2.20.0) Maps to `-XepAllSuggestionsAsWarnings`. Defaults to `false`.
 | `allDisabledChecksAsWarnings`    | Enables all Error Prone checks, checks that are disabled by default are enabled as warnings; maps to `-XepDisabledChecksAsWarnings`. Defaults to `false`.
 | `disableWarningsInGeneratedCode` | Disables warnings in classes annotated with `javax.annotation.processing.Generated` or `@javax.annotation.Generated`; maps to `-XepDisableWarningsInGeneratedCode`. Defaults to `false`.
 | `ignoreUnknownCheckNames`        | Maps to `-XepIgnoreUnknownCheckNames`. Defaults to `false`.
@@ -296,5 +297,5 @@ _Please note that all properties are [lazy](https://docs.gradle.org/current/user
 | `option(optionName)`              | Enables a boolean check option. Equivalent to `option(checkName, true)`.
 | `option(optionName, value)`       | Adds a check option with a given value. Value can be a boolean or a string, or a provider of string. Equivalent to `checkOptions.put(name, value)`.
 
-A check severity can take values: `DEFAULT`, `OFF`, `WARN`, or `ERROR`.  
+A check severity can take values: `DEFAULT`, `OFF`, `WARN`, or `ERROR`.
 Note that the `net.ltgt.gradle.errorprone.CheckSeverity` needs to be `import`ed into your build scripts (see examples above).

src/integrationTest/kotlin/net/ltgt/gradle/errorprone/GroovyDslIntegrationTest.kt

@@ -93,6 +93,7 @@ class GroovyDslIntegrationTest {
                     disableAllChecks = false
                     disableAllWarnings = false
                     allErrorsAsWarnings = false
+                    allSuggestionsAsWarnings = false
                     allDisabledChecksAsWarnings = false
                     disableWarningsInGeneratedCode = false
                     ignoreUnknownCheckNames = false

src/main/kotlin/net/ltgt/gradle/errorprone/ErrorProneOptions.kt

@@ -51,6 +51,13 @@ open class ErrorProneOptions constructor(
      */
     @get:Input val allErrorsAsWarnings = objectFactory.property<Boolean>().convention(false)
 
+    /**
+     * Turn all Error Prone suggestions into warnings; maps to `-XepAllSuggestionsAsWarnings`.
+     *
+     * This will be among the first arguments, so checks can then be demoted back to suggestions on a case-by-case basis.
+     */
+    @get:Input val allSuggestionsAsWarnings = objectFactory.property<Boolean>().convention(false)
+
     /**
      * Enables all Error Prone checks, checks that are disabled by default are enabled as warnings; maps to `-XepAllDisabledChecksAsWarnings`.
      *
@@ -251,6 +258,7 @@ open class ErrorProneOptions constructor(
                 booleanOption("-XepDisableAllChecks", disableAllChecks),
                 booleanOption("-XepDisableAllWarnings", disableAllWarnings),
                 booleanOption("-XepAllErrorsAsWarnings", allErrorsAsWarnings),
+                booleanOption("-XepAllSuggestionsAsWarnings", allSuggestionsAsWarnings),
                 booleanOption("-XepAllDisabledChecksAsWarnings", allDisabledChecksAsWarnings),
                 booleanOption("-XepDisableWarningsInGeneratedCode", disableWarningsInGeneratedCode),
                 booleanOption("-XepIgnoreUnknownCheckNames", ignoreUnknownCheckNames),

src/test/kotlin/net/ltgt/gradle/errorprone/ErrorProneOptionsTest.kt

@@ -56,6 +56,7 @@ class ErrorProneOptionsTest {
         doTestOptions { disableAllChecks.set(true) }
         doTestOptions { disableAllWarnings.set(true) }
         doTestOptions { allErrorsAsWarnings.set(true) }
+        doTestOptions { allSuggestionsAsWarnings.set(true) }
         doTestOptions { allDisabledChecksAsWarnings.set(true) }
         doTestOptions { disableWarningsInGeneratedCode.set(true) }
         doTestOptions { ignoreUnknownCheckNames.set(true) }
@@ -79,6 +80,7 @@ class ErrorProneOptionsTest {
             disableAllChecks.set(true)
             disableAllWarnings.set(true)
             allErrorsAsWarnings.set(true)
+            allSuggestionsAsWarnings.set(true)
             allDisabledChecksAsWarnings.set(true)
             disableWarningsInGeneratedCode.set(true)
             ignoreUnknownCheckNames.set(true)
@@ -240,6 +242,7 @@ class ErrorProneOptionsTest {
         assertThat(parsedOptions.isDisableAllChecks).isEqualTo(options.disableAllChecks.get())
         assertThat(parsedOptions.isDisableAllWarnings).isEqualTo(options.disableAllWarnings.get())
         assertThat(parsedOptions.isDropErrorsToWarnings).isEqualTo(options.allErrorsAsWarnings.get())
+        assertThat(parsedOptions.isSuggestionsAsWarnings).isEqualTo(options.allSuggestionsAsWarnings.get())
         assertThat(parsedOptions.isEnableAllChecksAsWarnings).isEqualTo(options.allDisabledChecksAsWarnings.get())
         assertThat(parsedOptions.disableWarningsInGeneratedCode()).isEqualTo(options.disableWarningsInGeneratedCode.get())
         assertThat(parsedOptions.ignoreUnknownChecks()).isEqualTo(options.ignoreUnknownCheckNames.get())