Updated

Author: Evanthx

core/src/main/java/io/temporal/samples/nexuswalkthrough/handler/ApprovalServiceImpl.java

@@ -109,7 +109,7 @@ public OperationHandler<RequestApprovalInput, RequestApprovalOutput> requestAppr
         (ctx, client, input) ->
             client.startWorkflow(
                 ApprovalWorkflow.class,
-                ApprovalWorkflow::requestApproval,
+                ApprovalWorkflow::runApproval,
                 input,
                 WorkflowOptions.newBuilder()
                     .setWorkflowId(ApprovalWorkflowId.forItem(input.getItemId()))
@@ -225,7 +225,7 @@ public OperationHandler<AttachApprovalContextInput, Void> attachApprovalContext(
           BatchRequest request = workflowClient.newSignalWithStartRequest();
           request.add(stub::attachContext, input.getNote());
           request.add(
-              stub::requestApproval,
+              stub::runApproval,
               new RequestApprovalInput(input.getItemId(), input.getRequester(), input.getAmount()));
           workflowClient.signalWithStart(request);
 

core/src/main/java/io/temporal/samples/nexuswalkthrough/handler/ApprovalWorkflow.java

@@ -42,7 +42,7 @@ public interface ApprovalWorkflow {
    * result, it has to be the Operation's declared output type.
    */
   @WorkflowMethod
-  RequestApprovalOutput requestApproval(RequestApprovalInput input);
+  RequestApprovalOutput runApproval(RequestApprovalInput input);
 
   /**
    * STEP 7 - A Signal. Fire-and-forget: the caller gets no result back, which is why a Signal is

core/src/main/java/io/temporal/samples/nexuswalkthrough/handler/ApprovalWorkflowImpl.java

@@ -38,7 +38,7 @@ public class ApprovalWorkflowImpl implements ApprovalWorkflow {
   private final List<String> notes = new ArrayList<>();
 
   @Override
-  public RequestApprovalOutput requestApproval(RequestApprovalInput input) {
+  public RequestApprovalOutput runApproval(RequestApprovalInput input) {
     // Placeholder. Real logic would apply policy, check limits, or call a risk service.
     activities.evaluateAutoDecision(input.getItemId(), input.getAmount());
 

core/src/test/java/io/temporal/samples/nexuswalkthrough/ApprovalWorkflowTest.java

@@ -52,7 +52,7 @@ private ApprovalWorkflow newApproval(String itemId) {
   public void decisionSubmittedThroughUpdateBecomesTheResult() {
     ApprovalWorkflow approval = newApproval("standing-desk");
     WorkflowClient.start(
-        approval::requestApproval,
+        approval::runApproval,
         new RequestApprovalInput("standing-desk", "dana@example.com", 1250.00));
 
     SubmitDecisionOutput ack =
@@ -70,8 +70,7 @@ public void decisionSubmittedThroughUpdateBecomesTheResult() {
   public void remindersAreCountedAndReportedWithTheDecision() {
     ApprovalWorkflow approval = newApproval("monitor-arm");
     WorkflowClient.start(
-        approval::requestApproval,
-        new RequestApprovalInput("monitor-arm", "dana@example.com", 900.00));
+        approval::runApproval, new RequestApprovalInput("monitor-arm", "dana@example.com", 900.00));
 
     approval.remindApprover();
     approval.remindApprover();
@@ -90,8 +89,7 @@ public void remindersAreCountedAndReportedWithTheDecision() {
   public void contextCanBeAttachedWhileTheApprovalIsPending() {
     ApprovalWorkflow approval = newApproval("laptop-dock");
     WorkflowClient.start(
-        approval::requestApproval,
-        new RequestApprovalInput("laptop-dock", "dana@example.com", 750.00));
+        approval::runApproval, new RequestApprovalInput("laptop-dock", "dana@example.com", 750.00));
 
     approval.attachContext("Approved in the Q3 ergonomics budget");
     SubmitDecisionOutput ack =
@@ -108,8 +106,7 @@ public void contextCanBeAttachedWhileTheApprovalIsPending() {
   public void aSecondDecisionIsRejected() {
     ApprovalWorkflow approval = newApproval("desk-lamp");
     WorkflowClient.start(
-        approval::requestApproval,
-        new RequestApprovalInput("desk-lamp", "dana@example.com", 600.00));
+        approval::runApproval, new RequestApprovalInput("desk-lamp", "dana@example.com", 600.00));
 
     approval.submitDecision(SubmitDecisionInput.Decision.DECISION_APPROVED);