Skip to content

Commit 951c9c4

Browse files
committed
Do not update workflow task stamp inside UpdateWorkflowTask()
1 parent 0bc2c0f commit 951c9c4

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

service/history/workflow/mutable_state_impl.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2859,9 +2859,8 @@ func (ms *MutableStateImpl) ApplyWorkflowExecutionPausedEvent(event *historypb.H
28592859
// Invalidate pending workflow task by incrementing the persisted stamp.
28602860
// This ensures subsequent task dispatch detects the change.
28612861
if ms.HasPendingWorkflowTask() {
2862-
workflowTask := ms.GetPendingWorkflowTask()
2863-
workflowTask.Stamp = workflowTask.Stamp + 1
2864-
ms.workflowTaskManager.UpdateWorkflowTask(workflowTask)
2862+
ms.executionInfo.WorkflowTaskStamp += 1
2863+
ms.workflowTaskManager.UpdateWorkflowTask(ms.GetPendingWorkflowTask())
28652864
}
28662865
return nil
28672866
}

service/history/workflow/workflow_task_state_machine.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1025,7 +1025,6 @@ func (m *workflowTaskStateMachine) UpdateWorkflowTask(
10251025
m.ms.executionInfo.WorkflowTaskHistorySizeBytes = workflowTask.HistorySizeBytes
10261026
m.ms.executionInfo.WorkflowTaskBuildId = workflowTask.BuildId
10271027
m.ms.executionInfo.WorkflowTaskBuildIdRedirectCounter = workflowTask.BuildIdRedirectCounter
1028-
m.ms.executionInfo.WorkflowTaskStamp = workflowTask.Stamp
10291028

10301029
m.ms.workflowTaskUpdated = true
10311030

0 commit comments

Comments
 (0)