Skip to content

Commit c76e337

Browse files
committed
fixes
1 parent d0495f9 commit c76e337

File tree

7 files changed

+12
-9
lines changed

7 files changed

+12
-9
lines changed

api/historyservice/v1/request_response.pb.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/history/client_gen.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cmd/tools/genrpcwrappers/main.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import (
77
"io"
88
"log"
99
"reflect"
10+
"runtime/debug"
1011
"slices"
1112
"strings"
1213

@@ -144,6 +145,8 @@ func verifyFieldExists(t reflect.Type, path string) {
144145
fieldName := codegen.SnakeCaseToPascalCase(part)
145146
f, ok := t.FieldByName(fieldName)
146147
if !ok {
148+
fmt.Printf("\nstack trace: path: [%s]\n", path)
149+
fmt.Println(string(debug.Stack()))
147150
codegen.Fatalf("%s has no field named %s", pathPrefix, fieldName)
148151
}
149152
if i == len(parts)-1 {

common/rpc/interceptor/logtags/history_service_server_gen.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

proto/internal/temporal/server/api/historyservice/v1/request_response.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1318,7 +1318,7 @@ message UpdateWorkflowExecutionOptionsResponse {
13181318
}
13191319

13201320
message PauseWorkflowExecutionRequest {
1321-
option (routing).workflow_id = "pause_request.workflow_execution.workflow_id";
1321+
option (routing).workflow_id = "pause_request.workflow_id";
13221322

13231323
// Namespace ID of the workflow which is being paused
13241324
string namespace_id = 1;

service/history/api/pauseworkflow/api.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ func Invoke(
1919
shard historyi.ShardContext,
2020
workflowConsistencyChecker api.WorkflowConsistencyChecker,
2121
) (resp *historyservice.PauseWorkflowExecutionResponse, retError error) {
22-
shard.GetLogger().Warn(fmt.Sprintf("Pausing workflow execution %s/%s by %s", req.GetPauseRequest().GetId(), req.GetPauseRequest().GetRunId(), req.GetPauseRequest().GetIdentity()))
22+
shard.GetLogger().Warn(fmt.Sprintf("Pausing workflow execution %s/%s by %s", req.GetPauseRequest().GetWorkflowId(), req.GetPauseRequest().GetRunId(), req.GetPauseRequest().GetIdentity()))
2323
namespaceEntry, err := api.GetActiveNamespace(shard, namespace.ID(req.GetNamespaceId()))
2424
if err != nil {
2525
return nil, err
@@ -40,7 +40,7 @@ func Invoke(
4040
nil,
4141
definition.NewWorkflowKey(
4242
namespaceID.String(),
43-
pauseRequest.GetId(),
43+
pauseRequest.GetWorkflowId(),
4444
pauseRequest.GetRunId(),
4545
),
4646
func(workflowLease api.WorkflowLease) (*api.UpdateWorkflowAction, error) {

service/history/handler.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2626,7 +2626,7 @@ func (h *Handler) PauseWorkflowExecution(ctx context.Context, request *historyse
26262626
return nil, h.convertError(errNamespaceNotSet)
26272627
}
26282628

2629-
workflowID := request.GetPauseRequest().GetId()
2629+
workflowID := request.GetPauseRequest().GetWorkflowId()
26302630
shardContext, err := h.controller.GetShardByNamespaceWorkflow(namespaceID, workflowID)
26312631
if err != nil {
26322632
return nil, h.convertError(err)

0 commit comments

Comments
 (0)