Skip to content

Commit 366e610

Browse files
committed
Add warnings from min
Signed-off-by: Filip Petkovski <[email protected]>
1 parent f9443da commit 366e610

File tree

1 file changed

+20
-5
lines changed

1 file changed

+20
-5
lines changed

execution/aggregate/accumulator.go

Lines changed: 20 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -146,13 +146,20 @@ func (c *maxAcc) AddVector(ctx context.Context, vs []float64, hs []*histogram.Fl
146146
}
147147

148148
fst, rem := vs[0], vs[1:]
149-
if _, err := c.Add(fst, nil); err != nil {
149+
warn, err := c.Add(fst, nil)
150+
if err != nil {
150151
return err
151152
}
153+
if warn != nil {
154+
warnings.AddToContext(warn, ctx)
155+
}
152156
if len(rem) == 0 {
153157
return nil
154158
}
155-
warn, err := c.Add(floats.Max(rem), nil)
159+
warn, err = c.Add(floats.Max(rem), nil)
160+
if err != nil {
161+
return err
162+
}
156163
if warn != nil {
157164
warnings.AddToContext(warn, ctx)
158165
}
@@ -211,17 +218,25 @@ func (c *minAcc) AddVector(ctx context.Context, vs []float64, hs []*histogram.Fl
211218
}
212219

213220
fst, rem := vs[0], vs[1:]
214-
if _, err := c.Add(fst, nil); err != nil {
221+
warn, err := c.Add(fst, nil)
222+
if err != nil {
215223
return err
216224
}
225+
if warn != nil {
226+
warnings.AddToContext(warn, ctx)
227+
}
217228
if len(rem) == 0 {
218229
return nil
219230
}
220-
warn, err := c.Add(floats.Min(rem), nil)
231+
232+
warn, err = c.Add(floats.Min(rem), nil)
233+
if err != nil {
234+
return err
235+
}
221236
if warn != nil {
222237
warnings.AddToContext(warn, ctx)
223238
}
224-
return err
239+
return nil
225240
}
226241

227242
func (c *minAcc) Add(v float64, h *histogram.FloatHistogram) (warning, error) {

0 commit comments

Comments
 (0)