Switch to slog #497
Merged
Switch to slog #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Contributor
Author
|
@harry671003 Can you help review this PR? This is a small change. |
harry671003
reviewed
Dec 3, 2024
| func TestMain(m *testing.M) { | ||
| parser.EnableExperimentalFunctions = true | ||
| goleak.VerifyTestMain(m) | ||
| goleak.VerifyTestMain(m, |
Contributor
There was a problem hiding this comment.
Would updating the opencensus-go package to latest help?
Contributor
Author
There was a problem hiding this comment.
I checked their master branch and the goroutine is still there https://github.com/census-instrumentation/opencensus-go/blob/master/stats/view/worker.go#L34.
Thanos main repo also ignores this function in the goleak test. But I am not sure why the problem only occur now. It should be always there
Contributor
|
Approving. Thanks Ben. |
harry671003
approved these changes
Dec 3, 2024
Contributor
Author
|
Merged the PR and I will rename the branch to |
yeya24
merged commit 1b81cc9
into
thanos-io:prometheus-update-65f610353919
5 of 7 checks passed
SungJin1212
pushed a commit
to SungJin1212/promql-engine
that referenced
this pull request
Jan 3, 2025
SungJin1212
pushed a commit
to SungJin1212/promql-engine
that referenced
this pull request
Feb 3, 2025
SungJin1212
pushed a commit
to SungJin1212/promql-engine
that referenced
this pull request
Feb 3, 2025
SungJin1212
pushed a commit
to SungJin1212/promql-engine
that referenced
this pull request
Feb 7, 2025
subhramit
pushed a commit
to subhramit/promql-engine
that referenced
this pull request
Feb 12, 2025
Signed-off-by: Subhramit Basu Bhowmick <[email protected]>
subhramit
pushed a commit
to subhramit/promql-engine
that referenced
this pull request
Feb 12, 2025
Signed-off-by: subhramit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Ye [email protected]
Update Prometheus version to prometheus/prometheus#14906