Skip to content

Logging: incremental flush leaves near-empty and empty completion groups (including a trailing empty 'Pipeline ✓' group) #3555

Description

@thomhurst

Category: logging UX — Breaking: no

The 60s incremental flush (ModuleOutputFlushInterval, PipelineOutputCoordinator.cs:60) renders <Module> ... (59s) groups mid-run, then ModuleOutputBuffer.cs:313-315 renders a completion group even when the completion buffer is empty. Run 30526435350: BuildSolutionsModule ... (59s 954ms) holds 212 lines while BuildSolutionsModule ✓ (1m 15s) holds 2; Flux gets two "..." groups before its ✓ group; the run ends with a fully empty Pipeline ✓ (13m 57s) group. Readers open the ✓ group expecting the output and find nothing.

Fix: title continuation/completion groups "(continued)"/"(1/2)" so readers know where the bulk lives (header text at ModuleOutputBuffer.cs:621-634), and suppress completion groups whose buffer is empty — especially the trailing Pipeline group. The flush design itself is sound.

Part of #3239 (round 2 addendum).

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Low: hygiene and nice-to-haves - wheneverenhancementNew feature or requestin-progressPicked up by an agent

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions