Upstream PlatformPkg for AMD Platform #742
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These change must be not upstream to tiano open source
cchen105
requested review from
abdattar,
changab and
pbgrimes
as code owners
Author
|
Hi, All. |
abdattar
requested changes
Feb 19, 2025
Contributor
abdattar
left a comment
abdattar
left a comment
There was a problem hiding this comment.
Will review the code.
few generic comment.
- change the copyright information to the 2025
- change INF version to the decimal
INF_VERSION = 1.30
| ## | ||
|
|
||
| [Defines] | ||
| INF_VERSION = 0x00010005 |
Contributor
There was a problem hiding this comment.
change to
INF_VERSION = 1.30
1. Add library to build. 2. Add GUID value, and PCD value. 3. Add dependency package, also add some keywords to skip.
cchen105
force-pushed
the
AMD_PlatformPkg
branch
from
d8f7116 to
fedf819
Compare
Author
|
Update copy right from 2024 to 2025. But, for the directory and file naming rule, will discuss internal and then follow up later. |
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send the first PR as draft pull request.
The first commit added by WA on my local machine, to pass CI build, will drop it when merge to main branch.
Separate each library with 1 commit, these library are independent from AMD AGESA.