Skip to content

[tink-worker] The version in the logs is not properly set #810

@jacobweinstock

Description

@jacobweinstock

Tink worker builds for container images pushed to quay.io/tinkerbell/tink-worker do not properly set the version. As a consequence, the container starts up with a log line showing the version to be devel. This devel is actually just hard-coded:

var version = "devel"

Expected Behaviour

The version reflects the tag or commit sha of the code from which it was built.

Current Behaviour

See the summary above.

Possible Solution

If we are to include the version, which I think is a good thing, we should set the version properly to a tag or commit sha.

Steps to Reproduce (for bugs)

Context

Your Environment

  • Operating System and version (e.g. Linux, Windows, MacOS):

  • How are you running Tinkerbell? Using Vagrant & VirtualBox, Vagrant & Libvirt, on Packet using Terraform, or give details:

  • Link to your project or a code example to reproduce issue:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions