Skip to content

Commit 8d493cc

Browse files
Add comment explaining why both CMAKE_ARGS and ENV compiler variables are needed
CMAKE_ARGS configures CMake with the correct compilers, while ENV variables ensure build tools and subprocesses use the right compilers, which is important for complex builds like Hermes.
1 parent b1331e3 commit 8d493cc

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

cmake/HermesExternal.cmake

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,10 @@ else()
9292
)
9393

9494
# Add Hermes as external project
95+
# Note: Both CMAKE_ARGS and ENV variables are used to ensure compiler consistency.
96+
# CMAKE_ARGS tells CMake which compilers to configure with, while ENV variables
97+
# ensure that build tools (make/ninja) and subprocesses use the correct compilers,
98+
# which is important for complex builds like Hermes that may spawn additional processes.
9599
ExternalProject_Add(hermes
96100
GIT_REPOSITORY ${HERMES_GIT_URL}
97101
GIT_TAG ${HERMES_GIT_TAG}

0 commit comments

Comments
 (0)