What would be the best/preferred way to get all errors?

[mpf82]

I want to get all errors when I have multiple semicolon separated statements. This is what I have come up with, but it does not look intuitive. Is there a better way to create my own Parser instance, so I can access parser.errors?

import sqlglot # 13.3.1.dev1
from sqlglot.errors import ErrorLevel
from sqlglot import Dialect, Parser

sql = """
SELECT . FROM t;
SELECT . FROM t;
SELECT * FROM .;
""".strip()
dia = Dialect()
p : Parser = dia.parser(error_level=ErrorLevel.IGNORE)
res = p.parse(dia.tokenize(sql), sql)
for e in p.errors:
    print(e.errors)

Output:

[{'description': 'Invalid expression / Unexpected token', 'line': 1, 'col': 9, 'start_context': 'SELECT ', 'highlight': '.', 'end_context': ' FROM t;\nSELECT . FROM t;\nSELECT * FROM .;', 'into_expression': None}]
[{'description': 'Invalid expression / Unexpected token', 'line': 2, 'col': 8, 'start_context': 'SELECT . FROM t;\nSELECT ', 'highlight': '.', 'end_context': ' FROM t;\nSELECT * FROM .;', 'into_expression': None}]
[{'description': 'Expected table name but got None', 'line': 3, 'col': 15, 'start_context': 'SELECT . FROM t;\nSELECT . FROM t;\nSELECT * FROM ', 'highlight': '.', 'end_context': ';', 'into_expression': None}]

By the way, there seems to be a one-off issue with the first error: notice the col: 9 - it should be col: 8, like in the second error, since the statements are identical.

[tobymao]

This looks fine to me.

[mpf82]

@tobymao thanks for the answer.

And what about the one-off column index? Should I create an issue for that?

Note that when I change the sql to

-- comment
SELECT . FROM t;
SELECT . FROM t;
SELECT * FROM .;

Then the output is:

[{'description': 'Invalid expression / Unexpected token', 'line': 2, 'col': 8, 'start_context': '-- comment\nSELECT ', 'highlight': '.', 'end_context': ' FROM t;\nSELECT . FROM t;\nSELECT * FROM .;', 'into_expression': None}]
[{'description': 'Invalid expression / Unexpected token', 'line': 3, 'col': 8, 'start_context': '-- comment\nSELECT . FROM t;\nSELECT ', 'highlight': '.', 'end_context': ' FROM t;\nSELECT * FROM .;', 'into_expression': None}]
[{'description': 'Expected table name but got None', 'line': 4, 'col': 15, 'start_context': '-- comment\nSELECT . FROM t;\nSELECT . FROM t;\nSELECT * FROM ', 'highlight': '.', 'end_context': ';', 'into_expression': None}]

As you can see, then it's col: 8 for the first and the second statement.

[georgesittas]

I'll take a look

[georgesittas]

@mpf82 1de5684

[Gwuala37]

Colon 8 should be into desired expression