Avoids OneOf type collision with enums and some nested types #1341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jknovi
force-pushed
the
oneof-conflict
branch
2 times, most recently
from
24b47b7 to
22461eb
Compare
When detecting if a oneof type will clash with other types we only compare against nested types, and for those only the snake_case version is validated against the oneof name. This allow room for conflicts when: - The collision would happen with an enum type. - The oneof name is a reserved word that when snaked gets sanitized as r#<word>. In this change the check for collisions is updated to consider enum types and compered against their capitalized camel case version which
jknovi
force-pushed
the
oneof-conflict
branch
from
22461eb to
839517e
Compare
caspermeijn
requested changes
Oct 3, 2025
Contributor
caspermeijn
left a comment
caspermeijn
left a comment
There was a problem hiding this comment.
Thank you for spotting this problem.
Thank you for creating this PR.
Thank you for adding a good test case!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When detecting if a oneof type will clash with other types we only compare against nested types, and for those only the snake_case version is validated against the oneof name. This allow room for conflicts when:
In this change the check for collisions is updated to consider enum types and compered against their capitalized camel case version which is the one that will be used on the type names causing the collision which makes builds using these protos to fail.
Added testcases that would repro these issues on the absence of this fix. Note that the test cases are legal protos that would be codegened without issues on other languanges.