Work on an improved pagination API #138
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in service of the pagination refactor.
Resolved conflict in one_model_sort_limit.rs by keeping the improved pagination implementation with Page objects and pagination metadata.
- Update pagination code to work with new Limit enum structure (PaginateForward vs Offset variants) - Fix engine integration for new ExecResponse structure - Add missing pagination field to ExecStatement initialization - Convert PaginateForward limits to Offset variants in planner to prevent SQL serializer panic - Implement basic has_next() pagination logic using +1 query technique - Clean up unused imports All tests now pass including the pagination test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.