Skip to content

Conversation

@elichai
Copy link
Contributor

@elichai elichai commented Mar 5, 2025

Motivation

JoinSet Implements FromIterator it's only natural that it also implements Extend

Solution

Implement Extend for JoinSet

@maminrayej maminrayej added A-tokio Area: The main tokio crate M-task Module: tokio/task labels Mar 5, 2025
@martin-g martin-g changed the title Implement Extend for JoinSet task: Implement Extend for JoinSet Nov 19, 2025
Comment on lines +659 to +660
/// # #[cfg(not(target_family = "wasm"))]
/// # {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ! to avoid block:

Suggested change
/// # #[cfg(not(target_family = "wasm"))]
/// # {
/// # #![cfg(not(target_family = "wasm"))]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems wasm-pack does not like it.
cargo test --doc passes OK locally.
I don't find any other usage of /// # #![cfg(...)] in the codebase.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the last two commits (git reset --hard) to fix the build.

@Darksonn Darksonn merged commit 749322d into tokio-rs:master Nov 25, 2025
168 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tokio Area: The main tokio crate M-task Module: tokio/task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants