Skip to content

Commit ddc9e38

Browse files
authored
fix naver.py with newer version API (#152)
* fix naver.py with newer version API remove naver.py print debugs. * add naver login mockup data, fix if picture isn't set, set None. before "" * fix naver test cases... Sorry! remove debugging print functions... * code quality fix!!
1 parent aea911e commit ddc9e38

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

fastapi_sso/sso/naver.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,9 @@ async def get_discovery_document(self) -> DiscoveryDocument:
2323
}
2424

2525
async def openid_from_response(self, response: dict, session: Optional["httpx.AsyncClient"] = None) -> OpenID:
26-
return OpenID(display_name=response["properties"]["nickname"], provider=self.provider)
26+
return OpenID(
27+
id=response["response"]["id"],
28+
display_name=response["response"]["nickname"],
29+
picture=response["response"]["profile_image"] or None,
30+
provider=self.provider,
31+
)

tests/test_openid_responses.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,11 @@
2828
id="test", provider="spotify", display_name="testuser", email="[email protected]", picture="https://myimage"
2929
),
3030
),
31-
(NaverSSO, {"properties": {"nickname": "test"}}, OpenID(display_name="test", provider="naver")),
31+
(
32+
NaverSSO,
33+
{"response": {"nickname": "test", "profile_image": "https://myimage", "id": "test"}},
34+
OpenID(id="test", display_name="test", provider="naver", picture="https://myimage"),
35+
),
3236
(
3337
MicrosoftSSO,
3438
{"mail": "[email protected]", "displayName": "Test User", "id": "test", "givenName": "Test", "surname": "User"},

0 commit comments

Comments
 (0)