0.16.6 precompilation with Julia 1.10

[pcarlip]

In Julia 1.10.9, Oceanostics fails to precompile with the following error:

PkgPrecompileError: The following 1 direct dependency failed to precompile:

Oceanostics 

Failed to precompile Oceanostics [d0ccf422-c8fb-49b5-a76d-74acdde946ac] to "/home/ceoas/carlipp/.julia/compiled/v1.10/Oceanostics/jl_sAjPm7".
ERROR: LoadError: UndefVarError: `BuoyancyField` not defined
Stacktrace:
 [1] include(mod::Module, _path::String)
   @ Base ./Base.jl:495
 [2] include(x::String)
   @ Oceanostics ~/.julia/packages/Oceanostics/OZP7i/src/Oceanostics.jl:1
 [3] top-level scope
   @ ~/.julia/packages/Oceanostics/OZP7i/src/Oceanostics.jl:157
 [4] include
   @ ./Base.jl:495 [inlined]
 [5] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::Nothing)
   @ Base ./loading.jl:2292
 [6] top-level scope
   @ stdin:4
in expression starting at /home/ceoas/carlipp/.julia/packages/Oceanostics/OZP7i/src/FlowDiagnostics.jl:1
in expression starting at /home/ceoas/carlipp/.julia/packages/Oceanostics/OZP7i/src/Oceanostics.jl:1
in expression starting at stdin:

Oceanostics 0.16.5 with Oceananigans 0.101.3 works fine. With Julia 1.12.2, Oceanostics 0.16.6 does precompile, but gives this output:

┌ Oceanostics
│  WARNING: Imported binding Oceananigans.BuoyancyField was undeclared at import time during import to FlowDiagnostics.
└  

[pcarlip]

Looks like it was removed in f01361e, possibly with a replacement in buoyancy_operation. See also discussion in #4967.

[tomchor]

Looks like it was removed in f01361e, possibly with a replacement in buoyancy_operation. See also discussion in #4967.

Thanks for flagging this. It was indeed removed. I thought I fixed everything in #216 but apparently I forgot this. Since CI passed (it uses Julia 1.12) I didn't notice it.

[tomchor]

As a note though, it's usually a good idea to use the Julia version used for CI, since that's the only version that's guaranteed to work. (Or at least have that version as a backup)

Opened up to fix this. I'll merge and tag a new version as soon as tests pass.

[pcarlip]

As a note though, it's usually a good idea to use the Julia version used for CI, since that's the only version that's guaranteed to work. (Or at least have that version as a backup)

I'll definitely switch soon, but I believe the CI only recently switched from 1.10 to 1.12 and I haven't had a chance to update all of the systems I use.

Thanks for addressing this so quickly!