Update the simple server example code for py3 modern syntax #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for twisted-pr-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
graingert
reviewed
Aug 23, 2022
twm
reviewed
Aug 28, 2022
Member
Author
|
Note that I have created this PR as an example of how you can contribute to the twisted web page. I will let others suggest "the right(tm)" examples and do the review. |
graingert
approved these changes
Sep 13, 2022
Member
|
@adiroiban I actually copy pasted the snippet to make sure it worked, and found a few bugs, I also ran it through isort and black. We might want to add blacken-docs when this is all rst-ied |
Member
Author
|
We can use just jinja to include external python file ... or HTML |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the code for py3 modern syntax
This is just a copy from #20 (comment)