Skip to content

Commit 173887d

Browse files
committed
Merge branch 'main' into v17/dev
# Conflicts: # src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/document-workspace.context.ts # src/Umbraco.Web.UI.Client/src/packages/property-editors/slider/types.ts
2 parents c674788 + 7819b6d commit 173887d

File tree

47 files changed

+1000
-109
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+1000
-109
lines changed

build/nightly-E2E-test-pipelines.yml

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -526,6 +526,23 @@ stages:
526526
CONNECTIONSTRINGS__UMBRACODBDSN: Data Source=(localdb)\MSSQLLocalDB;AttachDbFilename=|DataDirectory|\Umbraco.mdf;Integrated Security=True
527527
CONNECTIONSTRINGS__UMBRACODBDSN_PROVIDERNAME: Microsoft.Data.SqlClient
528528
additionalEnvironmentVariables: true
529+
# ExtensionRegistry
530+
WindowsExtensionRegistry:
531+
vmImage: "windows-latest"
532+
testFolder: "ExtensionRegistry"
533+
port: ''
534+
testCommand: "npx playwright test --project=extensionRegistry"
535+
CONNECTIONSTRINGS__UMBRACODBDSN: Data Source=(localdb)\MSSQLLocalDB;AttachDbFilename=|DataDirectory|\Umbraco.mdf;Integrated Security=True
536+
CONNECTIONSTRINGS__UMBRACODBDSN_PROVIDERNAME: Microsoft.Data.SqlClient
537+
additionalEnvironmentVariables: false
538+
LinuxExtensionRegistry:
539+
vmImage: "ubuntu-latest"
540+
testFolder: "ExtensionRegistry"
541+
port: ''
542+
testCommand: "npx playwright test --project=extensionRegistry"
543+
CONNECTIONSTRINGS__UMBRACODBDSN: Server=(local);Database=Umbraco;User Id=sa;Password=$(SA_PASSWORD);Encrypt=True;TrustServerCertificate=True
544+
CONNECTIONSTRINGS__UMBRACODBDSN_PROVIDERNAME: Microsoft.Data.SqlClient
545+
additionalEnvironmentVariables: false
529546
pool:
530547
vmImage: $(vmImage)
531548
steps:
@@ -657,4 +674,4 @@ stages:
657674
--data "$PAYLOAD" \
658675
"$SLACK_WEBHOOK_URL"
659676
env:
660-
SLACK_WEBHOOK_URL: $(E2ESLACKWEBHOOKURL)
677+
SLACK_WEBHOOK_URL: $(E2ESLACKWEBHOOKURL)

build/nightly-build-trigger.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ schedules:
88
displayName: Daily midnight build
99
branches:
1010
include:
11-
- v10/dev
1211
- v13/dev
12+
- v17/dev
1313
- main
1414

1515
steps:

src/Umbraco.Web.UI.Client/src/assets/lang/en.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2229,7 +2229,8 @@ export default {
22292229
legacyOptionDescription: 'This option is no longer supported, please select something else',
22302230
numberMinimum: "Value must be greater than or equal to '%0%'.",
22312231
numberMaximum: "Value must be less than or equal to '%0%'.",
2232-
numberMisconfigured: "Minimum value '%0%'must be less than the maximum value '%1%'.",
2232+
numberMisconfigured: "Minimum value '%0%' must be less than the maximum value '%1%'.",
2233+
rangeExceeds: 'The low value must not exceed the high value.',
22332234
invalidExtensions: 'One or more of the extensions are invalid.',
22342235
allowedExtensions: 'Allowed extensions are:',
22352236
disallowedExtensions: 'Disallowed extensions are:',

src/Umbraco.Web.UI.Client/src/libs/localization-api/localization.controller.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,15 @@ export class UmbLocalizationController<LocalizationSetType extends UmbLocalizati
114114
* @param {string} key - the localization key, the indicator of what localization entry you want to retrieve.
115115
* @param {...any} args - the arguments to parse for this localization entry.
116116
* @returns {string} - the translated term as a string.
117+
* @example
118+
* Retrieving a term without any arguments:
119+
* ```ts
120+
* this.localize.term('area_term');
121+
* ```
122+
* Retrieving a term with arguments:
123+
* ```ts
124+
* this.localize.term('general_greeting', ['John']);
125+
* ```
117126
*/
118127
term<K extends keyof LocalizationSetType>(key: K, ...args: FunctionParams<LocalizationSetType[K]>): string {
119128
if (!this.#usedKeys.includes(key)) {

src/Umbraco.Web.UI.Client/src/packages/block/block-grid/components/block-grid-area-config-entry/block-grid-area-config-entry.element.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ export class UmbBlockGridAreaConfigEntryElement extends UmbLitElement implements
7373
#renderBlock() {
7474
return this._key
7575
? html`
76-
<span>${this._alias}</span>
76+
<span class="alias">${this._alias}</span>
7777
<uui-action-bar>
7878
<uui-button label="edit" compact href=${this.workspacePath + 'edit/' + this._key}>
7979
<uui-icon name="icon-edit"></uui-icon>
@@ -110,14 +110,18 @@ export class UmbBlockGridAreaConfigEntryElement extends UmbLitElement implements
110110
background-color: var(--uui-color-disabled-standalone);
111111
}
112112
113+
:host([drag-placeholder]) {
114+
opacity: 0.2;
115+
}
116+
113117
uui-action-bar {
114118
position: absolute;
115119
top: var(--uui-size-2);
116120
right: var(--uui-size-2);
117121
}
118122
119-
:host([drag-placeholder]) {
120-
opacity: 0.2;
123+
.alias {
124+
padding: var(--uui-size-space-4);
121125
}
122126
`,
123127
];

src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-area-type-permission/block-grid-area-type-permission.element.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ export class UmbPropertyEditorUIBlockGridAreaTypePermissionElement
247247
}
248248
249249
uui-combobox strong {
250-
padding: 0 var(--uui-size-space-1);
250+
padding: var(--uui-size-space-2);
251251
}
252252
253253
uui-combobox-list-option {

src/Umbraco.Web.UI.Client/src/packages/block/block-grid/property-editors/block-grid-areas-config/property-editor-ui-block-grid-areas-config.element.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,12 @@ export class UmbPropertyEditorUIBlockGridAreasConfigElement
159159

160160
static override styles = [
161161
css`
162+
:host {
163+
display: flex;
164+
flex-direction: column;
165+
gap: var(--uui-size-2);
166+
}
167+
162168
.umb-block-grid__area {
163169
cursor: move;
164170
}

src/Umbraco.Web.UI.Client/src/packages/content/content-type/workspace/content-type-workspace-context-base.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ export abstract class UmbContentTypeWorkspaceContextBase<
9292
let { data } = await request;
9393

9494
if (data) {
95+
data = await this._processIncomingData(data);
9596
data = await this._scaffoldProcessData(data);
9697

9798
if (this.modalContext) {

src/Umbraco.Web.UI.Client/src/packages/content/content/types.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,11 @@ export interface UmbElementDetailModel {
1111
export interface UmbElementValueModel<ValueType = unknown> extends UmbPropertyValueData<ValueType> {
1212
culture: string | null;
1313
editorAlias: string;
14-
entityType: string;
14+
/**
15+
* @deprecated, we do not use entityType on values anymore. To be removed in Umbraco v.18.
16+
* Just remove the property.
17+
**/
18+
entityType?: string;
1519
segment: string | null;
1620
}
1721
// eslint-disable-next-line @typescript-eslint/no-empty-object-type

src/Umbraco.Web.UI.Client/src/packages/content/content/workspace/content-detail-validation-path-translator.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ describe('UmbValidationPropertyPathTranslationController', () => {
3232
value: 'value1',
3333
culture: null,
3434
segment: null,
35-
entityType: 'document-property-value',
3635
},
3736
],
3837
variants: [],

0 commit comments

Comments
 (0)